Comments (3)
What steps will reproduce the problem?
- Attempt to compile on Windows with MSVS.
What is the expected output? What do you see instead?
I expect it will compile and link. Instead it doesn't with a few errors, :-(.
What version of the product are you using? On what operating system?
r163
Please provide any additional information below.
Proposed fix here: https://codereview.appspot.com/29520043
from libaddressinput.
I propose that
we copy this function from Chrome: "std::string WideToUTF(const std::wstring&
input)" and use L"" string literals in data for "AX" and "JP" region codes. Here
are the original files that we would need to copy:
- WideToUTF8():
https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/utf_string_conversions.h&sq=package:chromium&type=cs
https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/utf_string_conversions.cc&sq=package:chromium&type=cs&rcl=1384937674
- ReadUnicodeCharacter(), WriteUnicodeCharacter(), IsValidCodePoint():
https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/utf_string_conversion_utils.h&sq=package:chromium&type=cs&l=40
https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/utf_string_conversion_utils.cc&sq=package:chromium&type=cs
- UTF utilities used in the conversion:
https://code.google.com/p/chromium/codesearch#chromium/src/base/third_party/icu/icu_utf.h&sq=package:chromium&type=cs&l=192&rcl=1384937674
https://code.google.com/p/chromium/codesearch#chromium/src/base/third_party/icu/icu_utf.cc&sq=package:chromium&type=cs
from libaddressinput.
Committed: https://code.google.com/p/libaddressinput/source/detail?r=166
from libaddressinput.
Related Issues (20)
- Ireland postcode should be on its own line HOT 1
- Cambodia zip format is wrong
- Update order of Taiwan's Subdivision (City/County)
- Incorrect ISO codes for Iran
- Philippines provinces renamed HOT 1
- Bahrain (BH) postcode regex incorrect HOT 6
- Dutch (NL) postal code regex matches invalid values HOT 2
- [Question] Are there any specific license restrictions on accessing the chormium-i18n.appspot.com data? HOT 1
- Error in Austrailia territory data HOT 1
- Make admin1 required in Australia and Turkey
- Erroneous sorting codes in French territories
- sub-region keys show as strikethrough text in wiki
- Spanish address format
- Wrong state_name_type for France
- aapt start failed on my Mac.
- Add non geographic UK Postcodes
- Add missing Brazilian City
- Taiwan's locality_name_type
- Street address line 2 does not have a field name (fails accessibility requirements) HOT 1
- Ireland requires addressline1, locality, subdivision HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libaddressinput.