Bahrain (BH) postcode regex incorrect about libaddressinput HOT 6 OPEN

Hi Ben. Yep, I will take a look and see if I'm able to make the change.

from libaddressinput.

I made a quick script to find all numbers on the page, the gist is here.

The table on https://en.youbianku.com/Bahrain does seem to match this 1-12 range, so the following regexp would suffice:

(?:\d|1[0-2])\d{2}

from libaddressinput.

@roelofr When I initially looked at the RegEx I too thought it would be okay but I had a play around and it seems to be ineffective for postcodes greater than 999: https://regex101.com/r/39cZU1/1/

I believe ^(1[0-1][0-9]{2}|12[0-1][0-6]|[1-9][0-9]{2}|10[1-9])$ might be a better solution: https://regex101.com/r/9nASya/1

from libaddressinput.

I believe ^(1[0-1][0-9]{2}|12[0-1][0-6]|[1-9][0-9]{2}|10[1-9])$ might be a better solution

This is very expressive for a regex, but mostly, it seems the Google API doesn't return start or end markers, possibly to allow finding postal codes in longer strings.

The pattern I posted matches 2103 matches 103, and ignores the 2. How could I miss that, thanks for the correction 👍

So, to fix this, we probably need to check for word markers or EOLs.
Since the last two digits are always required, I tried keeping them out of the alternate match.

So, my v2 would be:

(?:^|\b)(?:1[0-2]|[1-9])\d{2}(?:$|\b)

I ran it again your pattern, and added a 012, which should be invalid too. Results are here.

Small edit: made all groups non-capturing groups.

from libaddressinput.

(?:^|\b)(?:1[0-2]|[1-9])\d{2}(?:$|\b)

Looks good to me! I'd be more than happy with that being implemented.

from libaddressinput.

@sockix @sebsg are you able to assist with this change?

from libaddressinput.