Comments (4)
the difference appears to be that we don't receive state updates from scrollState.centerItemIndex and scrollState.centerItemScrollOffset the first time we display them. However if you navigate away and then back the updates are fired.
If I put some logging into Modifier.fadeAwayScalingLazyList state, I don't see state fired events, but a simple launched effect polling every 2 seconds does show the right values. And they both see the same list state instance.
@ExperimentalHorologistComposeLayoutApi
public fun Modifier.fadeAwayScalingLazyList(
initialIndex: Int = 1,
initialOffset: Int = 0,
scrollStateFn: () -> ScalingLazyListState,
): Modifier =
composed {
val scrollState = remember { scrollStateFn() }
val centerItemIndex = scrollState.centerItemIndex
val centerItemScrollOffset = scrollState.centerItemScrollOffset
LaunchedEffect(Unit) {
while (true) {
delay(2.seconds)
println("Manual: ${scrollState.centerItemScrollOffset} ${scrollState.centerItemIndex} $scrollState")
}
}
SideEffect {
println("State: $centerItemScrollOffset $centerItemIndex $scrollState")
}
from horologist.
Is this workaround still required given this issue has been fixed?
from horologist.
Let me check. Thanks!
from horologist.
I think that code is still an improvement, specifically this should cut down on recomposes.
val isInitial by remember(scrollState) {
derivedStateOf { scrollState.centerItemIndex == initialIndex }
}
from horologist.
Related Issues (20)
- Dependabot doesn't create update PRs for version 0.5.20 HOT 2
- Node.isNearby is not reliable HOT 3
- Detect if audio offload support Opus HOT 4
- Chip doesn't set onClick label
- AmbientAware composable unnecessarily recreates the whole tree HOT 2
- Horologist media router usage HOT 1
- Compose-Layout transitive dep on compose-navigation HOT 4
- Improve tracking Tile installation HOT 2
- Invalid doc links
- Review pipeline initializations
- Use correct padding for all responsive SLC
- Use Responsive Dialog consistently
- [Feature request] scalingLazyColumnDefaults does not support userScrollEnabled parameter HOT 10
- Stop a release off a release branch from generating docs HOT 1
- rotaryWithScroll in Dialogs HOT 4
- Uamp isn't restarting playback after pause and resume HOT 2
- Using rotaryWithScroll and onRotaryInputAccumulatedWithFocus simultaneously HOT 5
- AGP 8.3.0 upgrade is blocked
- Improve Tile tracking initialization
- Some datalayer docs out of date HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from horologist.