Git Product home page Git Product logo

Comments (4)

yschimke avatar yschimke commented on May 16, 2024

the difference appears to be that we don't receive state updates from scrollState.centerItemIndex and scrollState.centerItemScrollOffset the first time we display them. However if you navigate away and then back the updates are fired.

If I put some logging into Modifier.fadeAwayScalingLazyList state, I don't see state fired events, but a simple launched effect polling every 2 seconds does show the right values. And they both see the same list state instance.

@ExperimentalHorologistComposeLayoutApi
public fun Modifier.fadeAwayScalingLazyList(
    initialIndex: Int = 1,
    initialOffset: Int = 0,
    scrollStateFn: () -> ScalingLazyListState,
): Modifier =
    composed {
        val scrollState = remember { scrollStateFn() }

        val centerItemIndex = scrollState.centerItemIndex
        val centerItemScrollOffset = scrollState.centerItemScrollOffset

        LaunchedEffect(Unit) {
            while (true) {
                delay(2.seconds)
                println("Manual: ${scrollState.centerItemScrollOffset} ${scrollState.centerItemIndex} $scrollState")
            }
        }

        SideEffect {
            println("State: $centerItemScrollOffset $centerItemIndex $scrollState")
        }

from horologist.

luizgrp avatar luizgrp commented on May 16, 2024

Is this workaround still required given this issue has been fixed?

from horologist.

yschimke avatar yschimke commented on May 16, 2024

Let me check. Thanks!

from horologist.

yschimke avatar yschimke commented on May 16, 2024

I think that code is still an improvement, specifically this should cut down on recomposes.

        val isInitial by remember(scrollState) {
            derivedStateOf { scrollState.centerItemIndex == initialIndex }
        }

from horologist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.