Git Product home page Git Product logo

Comments (5)

gkdn avatar gkdn commented on May 4, 2024

If we let you to remove handlers by event then the next thing will be to provide an API to add them back.
That would just make these more complicated.
If you need to manage an event independently from the rest of the class, best thing to do is to add handlers for it without EventBinder.

from gwteventbinder.

ekuefler avatar ekuefler commented on May 4, 2024

Yeah, I agree with Goktug here. It's a lot easier to reason about how your class will work when either all @eventhandler methods are active or none of them are. Selectively removing handlers can make for really frustrating debugging when you're trying to figure out why one of your handlers isn't working and the rest all are.

If you want to be able to remove an individual handler, there's no reason you can't add it directly to the event bus and manage it outside of EventBinder - mixing @EventHandlers with normal calls to addHandler works fine. That way you can remove individual registrations while still having confidence that things declared as @EventHandlers will continue to work reliably.

Does that solution work for you?

from gwteventbinder.

christiangoudreau avatar christiangoudreau commented on May 4, 2024

My opinion is different, it is not unusual to have visibility handlers that are added and removed automatically depending if something is shown or not.

I've made the proposition into a post to be able to specify the EventBinder on wich a EventHandler can be bound simply by adding a parameter inside the annotation that takes the .class of the EventBinder to register the events.

from gwteventbinder.

gkdn avatar gkdn commented on May 4, 2024

@christiangoudreau, can you provide more concrete examples for your use cases?

from gwteventbinder.

christiangoudreau avatar christiangoudreau commented on May 4, 2024

Dynamic places, Dynamic tabs (linked to places), other cases when you want only the visible presenters to update when an event is thrown. (Servers update) Etc.

Doesn't happen often in simple apps though

from gwteventbinder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.