Comments (5)
@gokdogan, what do you think of this suggestion? This seems like a pretty reasonable request to me - Guava's eventbus appears to look at the parent's @subscribe methods, and this would also be consistent with registering this
as a handler on the EventBus as in eventBus.addHandler(ClickEvent.TYPE, this)
when ClickHandler
is implemented in the superclass.
Should be a fairly easy change to make and isn't likely to have serious backwards compatibility issues if you think it's a good idea.
from gwteventbinder.
Agreed. I actually didn't know it wasn't looking at the super class while binding the methods.
There might be some compatibility issues but I think we should still change the behavior.
from gwteventbinder.
Hello,
that would be great if you can implement it.
Thank you in advance.
Marco
from gwteventbinder.
I just pushed f908a36 implementing this, let me know what you think.
It's not quite as easy as just iterating up the class hierarchy and binding in the same way as is done for the current class, there are some subtle issues around how overrides should work. As currently implemented, I'm generating one handler per unique method signature found in the hierarchy. This should make overridden event handlers work correctly, since the overridden method will only be invoked once and it will be dispatched to the subclass. However, defining another handler for the same event (but a different method name) in a subclass will mean that the event will be dispatched to both the subclass and the superclass handler.
Try it out, if it seems like this gives the behavior we want I can push out a new version to Maven soon.
from gwteventbinder.
Hello,
i have tested the branch for "our" code and it works!
Thank you for the fast response and implementation!
Iยดm looking forward for the new version. :-)
With best regards
Marco
from gwteventbinder.
Related Issues (20)
- Example is not working HOT 2
- Compilation from master failed. HOT 3
- Would be nice if example had one instance of removing handlers HOT 1
- GWT 2.6.0-rc1 : com.google.gwt.dev.util.Preconditions removed HOT 1
- Error compiling on gwt 2.6.0-rc1 HOT 2
- @EventHandler for base abstract events HOT 4
- Update to GWT 2.6 HOT 8
- Missing EventBinder.gwt.xml HOT 6
- How to use gwteventbinder with guice during unit test HOT 7
- Using @EventHandler in derivative classes HOT 2
- EventBinder module definition is incompatible with separate compilation landed on GWT trunk HOT 4
- GWT dependencies have wrong dependency scope? HOT 4
- Is there a way to restrict which classes can catch events?
- Support generic events
- Is GWT 2.7 supported? HOT 3
- Activity and Presenter should be in same class or in the same package HOT 2
- transitive dependency on GWT 2.6.0 HOT 6
- Safari on Mac OSX HOT 1
- event binder generator does not use canonicalname for implements type. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gwteventbinder.