Zero-length writes are not allowed about gousb HOT 4 CLOSED

On Wed, Jul 31, 2019, 2:29 AM Sebastian Zagrodzki ***@***.***> wrote: Ok, so if I understand correctly, the only thing needed is the removal of the short-circuit? If an additional zero-length packet is needed after certain transfers (which is what LIBUSB_TRANSFER_ADD_ZERO_PACKET would have added automatically), the users will be able to request it manually by just initiating a zero-length write, so we don't need to worry about implementing some support for that transfer flag. Does that sound correct? @kylelemons <https://github.com/kylelemons> I think the code in question was inherited from the previous versions, https://github.com/google/gousb/blame/master/endpoint.go#L89. Can you think of any reason why we shouldn't allow zero-length transfers here? @QuLogic <https://github.com/QuLogic> FYI, in gousb Read/WriteTimeout is instead replaced with a context-aware read/write, see e.g. https://godoc.org/github.com/google/gousb#OutEndpoint.WriteContext — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#71?email_source=notifications&email_token=AACOVJITR5UGEYQNWWULNODQCFLPTA5CNFSM4IHW2NV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3GVJTI#issuecomment-516773069>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACOVJJYRP4UK4IYONIXZCDQCFLPTANCNFSM4IHW2NVQ> .