Git Product home page Git Product logo

gitprotocolio's Issues

Git Protocol Version not clear

There seems to be both Protocol V1 and V2 files in the codebase. Is the target of the repo to support both protocol versions or just focus on the V2 highlighted in googleblog a few weeks ago? Regardless, better clarity would be nice in the readme.

Additionally what are some of the future tasks? I would love to be a contributor.

The vision is not clear

In order to contribute, having clear vision help us to specify missions.

Could you please explain more the vision of this repository?
i.e: audience ... and so on.

Project status?

Hi,

I am reviewing the implementation here for my personal project and I think there are still some unfinished pieces.

The spec for V2 were also added some new functionality in recent months.

I was wondering if PR are accepted or would you prefer others maintaining a fork? Or perhaps contributing this to https://github.com/go-git/go-git which is still missing a Protocol V2 implementation?

Unable to parse git-upload-pack payload

How to reproduce

# Setup server
git clone https://github.com/sluongng/git-cache/
git checkout 07f1136c7d09c8281e4e0d8a8b96e3816dffbdac
go run .

# Setup client
# This should clone git.git from Github through the simple golang proxy
git -c http.extraHeader='GIT-CACHE-UPSTREAM: https://github.com' clone -vvv http://127.0.0.1:8080/git/git.git

Expected result

The middleware layer in sluongng/git-cache@07f1136#diff-0eb779b9e49d8e44b0f36923fdb8d87d5ee024f886eefc45deec4ec88380a087R56 should be able to parse the request body into ProtocolV2RequestChunk and serialize the Chunks as JSON and log them out.

Actual result

ls-ref command seems to work fine, but the one next git-upload-pack command failed to be parse by gitprotocolio

Unable to scan request: strconv.ParseUint: parsing "\x1f\x8b\b\x00": invalid syntax

Which most likely coming from

sz, err := strconv.ParseUint(string(data[:4]), 16, 32)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.