google / git-phabricator-mirror Goto Github PK

Right now, there is a bug in this logic here.

Specifically, this tries to read the comments from Phabricator, and write any new ones that it sees to git-notes. However, the only existing comments that it compares against are those attached to a review written in git-notes.

This means, that for reviews that do not have a corresponding request in git-notes, we will write the comments to git-notes over-and-over again until the review is closed.

To fix this, the logic should check that the first commit in the review has a review request written to git notes, and if it does not, then we should not mirror the comments into git-notes.