Git Product home page Git Product logo

Comments (6)

pleroy avatar pleroy commented on May 5, 2024

FWIW I have a port for Windows based on the pthread library at http://locklessinc.com/downloads/ (BSD 3-clause). Not quite ready for a pull request, but getting there.

from benchmark.

dmah42 avatar dmah42 commented on May 5, 2024

#64 has landed which gives us a working mingw port. does that help?

from benchmark.

mattyclarkson avatar mattyclarkson commented on May 5, 2024

@dominichamon, I tried having a go at getting VS2013 up and going but there are a few things missing with the C++11 support. I'll just brain dump here in case anyone can pick it up:

  • gettimeofday needs to be polyfilled in walltime.cc
  • (gm|local)time_r needs to be changed for (gm|local)time_s. arguments to swap over.
  • constexpr support is sketchy so things don't compile
  • noexcept wasn't supported
  • CMakeList.txt needs if (MSVC) to avoid all the GCC/Clang flag checks (not an issue as they fail gracefully, just looks weird)
  • By default cmake adds /Wall which turns on warnings that even the STL that is shipped with Visual Studio doesn't compile with. I'd suggest starting with /W0 and slowly cranking that up to /W4 putting the necessary /wdXXXX in the CMakeList.txt or the pragma warning() around the offending areas. It would be great to have a clean MSVC build at high warning levels as it might catch things that GCC/Clang might miss

It's almost there, just needs a bit of love. cmake -G "Visual Studio 12 2013" gets things going.

Once the Visual Studio build is going the appveyor support to continuously check for MSVC support can be added by implementing msbuild like cppformat does here. Will just have to add the necessary lines to appveyor.yml when if "%compiler_name%"=="msvc".

from benchmark.

KindDragon avatar KindDragon commented on May 5, 2024

Relate to PR #175

from benchmark.

EricWF avatar EricWF commented on May 5, 2024

Closing since the Windows build seems to be working and Appveyor is testing it on every commit.

from benchmark.

syoyo avatar syoyo commented on May 5, 2024

Super cool! Thank you!

from benchmark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.