[FR] Large File Support about benchmark HOT 5 CLOSED

let's keep the two separate for now. LFS has been around for a long time and should be easy enough. 64-bit time_t is a newer project and still semi-influx.

from benchmark.

(I can work on this.)

from benchmark.

have you seen this issue anywhere? ifstream is only used in context of opening sysinfo files ("/proc/cpuinfo" and similar) none of which should be "large". ofstream is used to write out files and i suppose these could become large for larger projects, but maybe not on smaller platforms (as they couldn't run such large projects, i suppose).

from benchmark.

LFS isn't just about reading the content of large files. inodes can be 64-bit which means any attempt to stat will fail too. and that can be tricky to reproduce as it's up to the underlying filesystem whether/when it returns an inode # that doesn't fit into 32-bits. enabling LFS costs basically nothing.

i'll also note that in order to support 64-bit time_t, you'll need to enable LFS eventually anyways.

from benchmark.

Thanks @vapier for clearer information and sorry for my initial vague arguments.

IIUC, for 64-bit time_t support (to prevent Y2K38), we only need to add -D_TIME_BITS=64 to the compile flag if LFS is already there.
If we want to do so, I can adjust #1726 to include it (and rename it to "Enable Large-file Support + 64-bit time_t").

from benchmark.