goodrequest / goodpersistence Goto Github PK

@andrej-jasso @sebastianmraz Did you consider to add functionality to handle errors?

is it possible to add an attribute for synchronization via iCloud?
kSecAttrSynchronizable

I am unable to use KeychainWrapper. It gives me Cannot find 'KeychainWrapper' in scope error. Xcode shows this class as unavailable in current scope. @KeychainValue decorator works correctly though. I imported required modules.

I did the Project Clean / Clean Derived Data / Xcode Restart.

• Device: iPhone 15 Pro Simulator
• Xcode: Version 15.4 (15F31d)
• Version 2.3.0

Does anyone have an idea what might be wrong?

Describe the bug
Accessing keychain value saving from multiple thread at ones fails to register into publisher.

To Reproduce
Steps to reproduce the behavior:
Tests that fail written in this branch
feature/multithreadedStorageTests

Expected behavior
All values are registered in the publisher.

Suggested
Actor support would fix this.

Describe the bug
In case we are subscribed to valuePublisher, after first error passed to subject, subject completes and is not reinitialized. After error we are unable to receive new values passed to keychain.

To Reproduce
Steps to reproduce the behavior:

1. Create Keychain
2. Subscribe to valuePublisher
3. Try to force error inside keychain property
4. Pass valid value to property
5. New value is not receiver in valuePublisher

Expected behavior
After receiving error, I am able to receive next values.

Additional context
Suggested solution:

1. private let newSubject: PassthroughSubject<Either<T, KeychainError>, Never> = PassthroughSubject()
2. private let newSubject: PassthroughSubject<Event<T, KeychainError>, Never> = PassthroughSubject()

In SwiftUI there is a property wrapper @AppStorage that gives developer the ability to store raw data (Strings, numbers, booleans, URLs) in cache. User interface then automatically updates itself when the underlying data change.

It should be possible to integrate the same functionality using DynamicProperty protocol into GoodPersistence property wrappers to extend system functionality to save any Codable data as JSON string, automatically (de)serialize when required, and auto-update the UI on property change.

It might be possible to integrate the same functionality for values stored in keychain also.