goodclover / osm-discord-bot Goto Github PK

The current code is a monolithic one-file mess.

At some point the following should probably be done:

• A bunch of constants are defined in main.py that should probably be moved to the config.
• Split everything into multiple files so it is better organised. Not sure how they work but I think this is what Cogs are for, slash-command supports them.
• Clean the type annotations up, some are missing, some wrong. It doesn't help that discord.py doesn't have them (slash-command I think does).
• Better code comments.

At line 742, regex currently supports only formats like node/1234. Requesting feature to support phrases like nodes 1, 2, 5 and 6 or 3.

Half-tested solution ELM_INLINE_REGEX = rf"{SS}(node|way|relation)(?:s? |\/)({POS_INT}(?:(?:, | and | or | )(?:{POS_INT}))*){SE}. It might be good or bad idea to unify similar regex for lines 742, 743 and 744. New regex supports array separators , , and and or while accepting old node/123 format.

Additional group-based regex processing may need to be implemented in on_message(). Since regex doesn't support repeating capturing groups, entire list of element ID-s are matched as single group (e.g 1, 2, 5 and 6 or 3) and needs next regex to match each {POS_INT} to find element ID-s individually.
For example line 755 becomes elms = [(elm[0], tuple(re.findall('\d+', elm[1]))) for elm in re.findall(ELM_INLINE_REGEX, msg.clean_content) instead of

PS. There's typo in readme.

At current /close_suggestion is shown in the list for people that don't have permission.
There is a check in place to make sure they are allowed, but it still shows in the list of commands.

I'm not sure if Discord supports this, maybe it would be good to split all powerful commands into a simple /power or /admin and then use sub-commands for the individual things?

If OSM-Discord-bot is going to replace Dyno's custom commands, it would be nice if it supported accepting and rejecting the posted suggestions in the form of a moderator-only command that could refer to the suggestion's (TBI) ID.

This would either append to the original message or create a reply with a message like "Suggestion X has been accepted/rejected".

To show bot in the action.

At current, Matrix users are unable to use slash-commands, but they can use inline detection or "traditional" commands (e.g. ?help).
Adding the ability for the bot to detect if a message starts with /, and then treat it like a slash command would enable bridged users to use the commands.

Note that bridged users appear as bots.