goobta / expression-editor Goto Github PK

Need to ensure that the left to right ordering of the tree is maintained. See

Important Note: While you could apply the same logic to claim (correctly) that the expression 10xz can be rearranged into zx10, you should not do so in this project. In particular, your parser should preserve the left-to-right ordering of the sub-expressions in the parse tree.

in the assignment page.

"nuff said

Creates a copy but not a deep copy

Expression.java now has a getNode() function. That means that all the chill'n of Expression.java need to implement getNode()

For example, in the parenAtStartAndEndButNotSameExpression test case, we have the expression
(420 + (32 + x)) + (911 + 69 + x)

The code goes into the first conditional, stating that "damn, since there is an open paren and a closed one at the beginning and the end, respectively, then this is a valid expression!".

Seems like the x coordinate of the mouse pointer needs to be further down than where the expression actually is.

Need to create a tester other than Whitehill's

Check out SimpleExpressionParser. In almost all of the if conditionals in the program, the following lines are always there:

if (childExpression1 == null || childExpression2 == null) {
    return null;
}

childExpression1.setParent(expression);
childExpression2.setParent(expression);

expression.addSubexpression(childExpression1);
expression.addSubexpression(childExpression2);

return expression;

Any way we could factor it out?