gomint / jraknet Goto Github PK

it still points to old repo.gomint.io

We're working on a game, We're going to use RakNet on the client side, if we use jRakNet on the server side, What we need to do to make it work? other Suggestions? Thanks!

If an exception was to occur in a thread generated by the ThreadFactory used from the open Socket, the exception would not be output to the SLF4J Logger.

I have written a fix for this on JungleTree's fork, but it will need backporting for GoMint.

See the fix within the socket class to see how I'm doing it.

This is more of a question than an issue (though it is an issue that is in your code). This is referencing the comment In io.gomint.jraknet.Socket.java between lines 36 and 51.

We allocate buffers able to hold twice the maximum MTU size for the reasons listed below:

Somehow I noticed receiving datagrams that exceeded their respective connection's MTU by
far whenever they contained a Batch Packet. As this behaviour comes out of seemingly
nowhere yet we do need to receive these batch packets we must have room enough to actually
gather all this data even though it does not seem legit to allocate larger buffers for this
reason. But as the underlying DatagramSocket provides no way of grabbing the minimum required
buffer size for the datagram we are forced to play this dirty trick. If - at any point in the
future - this behaviour changes, please add this buffer size back to its original value:
MAXIMUM_MTU_SIZE.

Examples of too large datagrams:

• Datagram containing BatchPacket for LoginPacket: 1507 bytes the batch packet alone (5th of March 2016)

Suggestions:

• Make this value configurable in order to easily adjust this value whenever necessary

First; is this an issue with jRakNet? Or is it coming from MCPE? If I were to use jRakNet on a server and connect it with a client using jRakNet, would I ever have an issue of batch packets being over the MTU? I assume that the issue is on MCPE's side. I am asking this because I am investigating using jRakNet as networking for my game.

Second; I used to develop a server for MCPE. I didn't get far in writing actual server software, but I had studied MCPE's (and RakNet, by accident at the time) protocol. Things have changed since then, of course, but from my understanding RakNet determined the MTU between the client and the server during connection. Might this be the issue? MCPE would determine the max MTU and send as many packets that fit. I might have misinterpreted the documentation at the time, it's been several years.