Git Product home page Git Product logo

Comments (6)

dsymonds avatar dsymonds commented on August 18, 2024

reflect.DeepEqual doesn't work with protos. You need to use proto.Equal.

I'll make the extension failure return an error instead of printing.

I don't know why you're getting an EOF there. That's weird.

from protobuf.

dvyukov avatar dvyukov commented on August 18, 2024

reflect.DeepEqual doesn't work with protos. You need to use proto.Equal.

But still non-empty extension can't be equal to nil.

I don't know why you're getting an EOF there. That's weird.

You can run the test locally to debug.

from protobuf.

dsymonds avatar dsymonds commented on August 18, 2024

aece6fb updates the text formatter to return an error instead of printing.

from protobuf.

dsnet avatar dsnet commented on August 18, 2024

Closing as duplicate of #667, which is to investigate all usages of log.Print

from protobuf.

dvyukov avatar dvyukov commented on August 18, 2024

#667 does not cover the main part of this "Part of the message gets lost".

from protobuf.

dsnet avatar dsnet commented on August 18, 2024

"Part of the message gets lost".

Are you referring to the fact that round-trip Marshal/Unmarshal produces different results? The proto text format does not have the property of full round-trip stability in the presence of unknown fields. This is not specific Go.

from protobuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.