editions: maps are incorrectly serialized if file has default message encoding of DELIMITED about protobuf HOT 8 CLOSED

@stapelberg, @lfolger, have either of you seen this? Now that v27.0 of protoc is released (which includes some add'l minor changes to descriptor.proto), it would be nice to get another release soon that has the latest v27 version incorporated into the descriptorpb package as well as a fix to this bug. If it would help, I can probably work on creating pull requests for these.

from protobuf.

(Lasse is on vacation until June 10th.)

Thanks for the report. We haven’t encountered this issue elsewhere.

Yes, if you send pull requests, that would help to get a new release out. I’m out of office on Thursday and Friday, so timeline-wise, I think we should be able to cut a new release next week.

To confirm: importing the new descriptor version merely side-steps this issue, yes? For delimited encoding, it sounds like we still need a fix eventually.

from protobuf.

To confirm: importing the new descriptor version merely side-steps this issue, yes? For delimited encoding, it sounds like we still need a fix eventually.

Sorry that I brought up the new descriptor in the same sentence. They are separate -- that and a fix to this bug are two independent things I'd like to get into a release.

from protobuf.

Ah, thanks for clarifying. Will you also send a PR for the bug fix? I’m afraid we’re currently stretched very thin (with others on vacation and parental leave), so to make progress in a reasonable time frame we’re reliant on contributions. Thanks

from protobuf.

Will you also send a PR for the bug fix?

Just opened one: https://go-review.googlesource.com/c/protobuf/+/588976

from protobuf.

Apologies for the delay, I was out sick the last few days.

Should I start a new release, or would you like to wait for https://go.dev/cl/589336 to land as well?

from protobuf.

We can wait to see the outcome of that other CL. If it is approved, it would be nice for it to be included as well.

from protobuf.