Comments (7)
Sorry for the inconvenience! github.com/golang/protobuf
v1.5.4 should be compatible with google.golang.org/protobuf
v1.33.0.
The problem, for reference, is that:
descriptor.proto
(part of the upstream protobuf project) dropped theFileOptions.php_generic_services
field.google.golang.org/protobuf
includes the generated package fordescriptor.proto
.google.golang.org/protobuf
v1.33.0 updatesdescriptor.proto
, resulting in the constdescriptorpb.Default_FileOptions_PhpGenericServices
being removed.github.com/golang/protobuf
, for historical reasons, includes a stub version ofdescriptor.proto
that forwards all its symbols to the canonical one ingoogle.golang.org/protobuf
.github.com/golang/protobuf
v1.5.3 is now incompatible withgoogle.golang.org/protobuf
v1.33.0, because it references a symbol that doesn't exist.
This is fixed in v1.5.4 by regenerating the forwarding package.
In retrospect, a better fix might have been in google.golang.org/protobuf
: We could have added a declaration for Default_FileOptions_PhpGenericServices
to that package for backwards compatibility. If we'd detected the problem in time, we could have done that in the v1.33.0 release and maintained compatibility with v1.5.3.
We should have a test that ensures this doesn't happen again in the future.
from protobuf.
This blocks picking up a fix for https://groups.google.com/g/golang-announce/c/ArQ6CDgtEjY/m/oLMrdq_GBQAJ in code bases that still uses deprecated Go package. While the "correct" solution is to stop using the deprecated package, it is not really possible to do fast. And running vulnerable code is not nice... Please consider releasing a new compatible github.com/golang/protobuf version.
from protobuf.
+1 I encountered this on celestiaorg/celestia-app#3155. See this error.
from protobuf.
Gah, apologies, I didn't expect that.
I think we have to make an updated version of github.com/golang/protobuf that updates descriptor.pb.go
, thanks to a backwards-incompatible change in descriptor.proto
.
from protobuf.
Does google.golang.org/protobuf need a newer version than v1.33.0? I saw github.com/golang/protobuf (v1.5.4) already.
from protobuf.
Seems resolved via #1597 because https://github.com/golang/protobuf/releases/tag/v1.5.4 works for me.
from protobuf.
So this is weird. I upgraded google.golang.org/protobuf to 1.33.0 in my master branch (openshift/hive#2231) where github.com/golang/protobuf was still at 1.5.3. Worked fine.
Applied that same change to a recent release branch (openshift/hive#2239). Worked fine.
Applied that same change to an earlier release branch (openshift/hive#2240) and ran into this problem.
All three branches started with github.com/golang/protobuf at 1.5.3. But only that third one broke.
from protobuf.
Related Issues (20)
- timestamppb.AsTime is incorrectly implemented for nil/zero values HOT 2
- missing replace in go.mod HOT 1
- protojson: fail to unmarshal JSON with reserved fields HOT 19
- Parsing protoc plugin option containing ',' HOT 5
- go_features.proto has incorrect package and error-prone file path HOT 5
- Tracking issue: Fully Lazy Extension decoding HOT 7
- feature: Generate test client / `bufconn` constructors HOT 4
- v1.33.0 breaks bazel build HOT 14
- Reflection: protopath parsing and path+message access HOT 7
- Proposal: Set go.mod Go language version to oldest supported Go version (1.21 currently) HOT 8
- Proposal: Add `Override` mode to `proto.Merge` HOT 2
- editions: maps are incorrectly serialized if file has default message encoding of DELIMITED HOT 8
- protodesc: too strict about proto3 field names when creating descriptors from FileDescriptorProto
- undefined: descriptorpb.Default_FileOptions_PhpGenericServices HOT 2
- `ProtoReflect().GetUnknown()` Not Working HOT 4
- Editions language feature: (pb.go).struct_tag HOT 11
- encoding/protojson: handling google.protobuf.Empty HOT 15
- Make M option overwrite `option go_package` in the `.proto` file (as opposed to return an error) HOT 5
- related to #1054 and similar "plugin output is unparseable" errors HOT 4
- Random 0xfeff / ZERO WIDTH NO-BREAK SPACE being added to returned string values HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protobuf.