godoc refactoring adds unnecessary comment for types and ignores value declarations about godoctor HOT 2 CLOSED

The original issue is actually how we're checking for the godoc comment. Currently checking the ast.TypeSpec doc field for an existing comment, which is only present with declaration groups. Have to use the doc field in ast.GenDecl in the case of a non-group declaration.

This also means we weren't properly checking for godoc comments for value declarations (constants and vars).

Question is: for group declarations, do we want to comment on the declaration or each specified name? It's valid to have a single godoc comment for the entire group or for each exported declaration.

Example, given this:

const (
    A = "foo"
    B = "bar"
)

Do we want this:

// TODO: NEED COMMENT INFO
const (
    A = "foo"
    B = "bar"
)

Or this:

const (
    // A TODO: NEED COMMENT INFO
    A = "foo"
    // B TODO: NEED COMMENT INFO
    B = "bar"
)

@joverbey

from godoctor.

@roberthorn Whatever you think; your call. Which one do people want most of the time? Worst case, we could add a boolean flag to the refactoring to toggle the behavior, but I'd prefer to just do something reasonable by default.

I was trying to use, as an example, https://golang.org/pkg/go/token/#Token - source at https://golang.org/src/go/token/token.go#L13 - but I probably need to look at some more godoc to form an opinion

from godoctor.