godoctor rename issue about godoctor HOT 4 CLOSED

I'm not able to reproduce this in Vim. Assuming the following code:

package main

import "fmt"

func main() {
        num := 1
        fmt.Println(num)
}

doing num -> n -> num works every time.

Basically it's having trouble finding the variable from your selection.

Messing with godoctor, it seems that the -pos offset,len style isn't very consistent, I'm able to reproduce the problem with variable n with godoctor -file main.go -pos 44,1 rename num. Seems to only be a problem with single character variables.

I'm pretty sure the Vim plugin uses the -pos startrow,startcol:endrow,endcol format, which if you try godoctor with godoctor -file main.go -pos 6,5:6,5 rename num, it will work. Be wary of tabs/spaces though.

@rdallman @joverbey sound right?

from godoctor.

thanks for debugging and raising issue. should we require the startrow,startcol:endrow,endcol syntax in the api to avoid such issues in the future?

from godoctor.

Thanks I'll try the longer format as suggested. Will report back!

from godoctor.

The suggested format works much better.

-pos startrow,startcol:endrow,endcol

And now I have applied the change to the Emacs package.

@roberthorn @rdallman Thanks for helping me sort this out.

from godoctor.