gocodebox / lifterlms-labs Goto Github PK

Experimental, conceptual, and possibly silly new features to improve and enhance the functionality of the LifterLMS core

PHP 99.97% JavaScript 0.03%

lifterlms-labs's People

Contributors

Stargazers

Watchers

Forkers

eri-trabiccolo kimcoleman actuallyakash

lifterlms-labs's Issues

Debug Display Causes White Screen with Lifti

Enable Divi
Enable LifterLMS Labs Lifti
Enable Debug Display
Go into the course builder for any course with these settings enabled.
The builder opens to a blank white screen but none of the deprecation notices that should show up with debug.

The workaround is easy enough turn off debug display because it really shouldn't be on anyway, but this shouldn't break builder display screen when trying to display the notices with debug display enabled.

Beaver Builder: 2.0 Compatibility

Branding: Add quiz-related CSS overrides

Lab: Beaver Builder - doesn't support sales page content changes from LifterLMS 3.20

Action Manager: Remove Featured Image Action

LifterLMS hasn't added featured images since 2.x so this hook doesn't work and shouldn't exist

Lifti: Deprecated filter `llms_get_quiz_theme_settings` logged when accessing the builder

Reproduction Steps

With the Divi theme enable "Lifti"
Access the course builder on a course with a quiz

Expected Result

no deprecation warning logged in the llms-log

Actual Result

deprecation warning logged in the llms-log

When the debug display is active this warning breaks the builder. In order to avoid this, customer can disable the debug display e.g. adding the following to their wp-config.php before /* That's all, stop editing! Happy blogging. */

define( 'WP_DEBUG', true );
define( 'WP_DEBUG_DISPLAY', false );

Error Log

08-21-2020 @ 11:07:44 - Filter llms_get_quiz_theme_settingsdeprecated since 3.17.6. For more information see new methods at https://lifterlms.com/docs/course-builder-custom-fields-for-developers/

System Info

LifterLMS 4.3.3
LifterLMS Labs 1.5.3
Divi *

LifterLMS Labs(Action Manager) don't work anymore

Action Manager in LifterLMS Labs does not hide the elements on the course page anymore.

HS-122914

test

Lifti: Add support for LifterLMS Private Areas

Labs does not get elements removed

Reproduction Steps

Install LifterLMS and LifterLMS Labs
Try to remove the syllabus or any other element in the "Single Course Actions"
The syllabus does not remove on the course page.

Expected Behavior

The syllabus or the element selected should be removed

Actual Behavior

Does not remove

Error Messages / Logs

Include any relevant error messages or log files

<!-- Paste error logs / backtraces below this line -->
N/A

System and Environment Information

System Report

Wordpress
-------------------------------------------

Home Url: [removed]
Site Url: [removed]
Login Url: [removed]/wp-login.php
Version: 5.8.3
Debug Mode: No
Debug Log: No
Debug Display: Yes
Locale: en_US
Multisite: No
Page For Posts: Blog (#25) [[removed]/blog/]
Page On Front: Home (#530) [[removed]/]
Permalink Structure: /%postname%/
Show On Front: page
Wp Cron: Yes


Settings
-------------------------------------------

Version: 5.7.0
Db Version: 5.7.0
Course Catalog: Course Library (#422) [[removed]/course-library/]
Membership Catalog: Membership Catalog (#402) [[removed]/memberships/]
Student Dashboard: Students Dashboard (#404) [[removed]/studentdashboard/]
Checkout Page: Purchase (#403) [[removed]/?page_id=403]
Course Catalog Per Page: 9
Course Catalog Sorting: title,ASC
Membership Catalog Per Page: 9
Membership Catalog Sorting: menu_order,ASC
Site Membership: Not Set
Courses Endpoint: my-courses
Edit Endpoint: edit-account
Lost Password Endpoint: lost-password
Vouchers Endpoint: redeem-voucher
Autogenerate Username: yes
Password Strength Meter: yes
Minimum Password Strength: medium
Terms Required: no
Terms Page: Not Set
Checkout Names: required
Checkout Address: hidden
Checkout Phone: hidden
Checkout Email Confirmation: yes
Open Registration: yes
Registration Names: required
Registration Address: hidden
Registration Phone: hidden
Registration Voucher: optional
Registration Email Confirmation: yes
Account Names: required
Account Address: optional
Account Phone: optional
Account Email Confirmation: yes
Confirmation Endpoint: confirm-payment
Force Ssl Checkout: no
Country: CA
Currency: CAD
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Decimals: 2
Trim Zero Decimals: no
Recurring Payments: yes
Email From Address: [removed]
Email From Name: [removed]
Email Footer Text: [email protected]
Email Header Image:
Cert Bg Width: 800
Cert Bg Height: 616
Cert Legacy Compat: no


Constants
-------------------------------------------

LLMS_REMOVE_ALL_DATA: undefined
LLMS_REST_DISABLE: undefined
LLMS_SITE_FEATURE_RECURRING_PAYMENTS: undefined
LLMS_SITE_IS_CLONE: undefined


Gateways
-------------------------------------------

Stripe: Enabled
Stripe Test Mode: Enabled
Stripe Logging: no
Stripe Order: 1
Manual: Enabled
Manual Logging: no
Manual Order: 1


Server
-------------------------------------------

Mysql Version: 8.0.27
Php Curl: Yes
Php Default Timezone: UTC
Php Fsockopen: Yes
Php Max Input Vars: 1000
Php Max Upload Size: 8 MB
Php Memory Limit: 256M
Php Post Max Size: 8M
Php Soap: No
Php Suhosin: No
Php Time Limt: 600
Php Version: 7.4.27
Software: Apache
Wp Memory Limit: 40M


Browser
-------------------------------------------

HTTP USER AGENT: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101 Firefox/95.0


Theme
-------------------------------------------

Name: Astra Child
Version: 1.8.5.1560264205
Themeuri: https://wpastra.com/
Authoruri: https://wpastra.com/about/
Template: astra
Child Theme: Yes
Llms Support: Yes


Plugins
-------------------------------------------

Astra Bulk Edit: 1.2.6
Astra Customizer Reset: 1.0.5
Child Theme Generator: 2.2.7
Custom Adobe Fonts (Typekit): 1.0.18
Custom Fonts: 1.3.3
Custom Template for LifterLMS: 1.0.3
Elementor: 3.5.3
Google Analytics for WordPress by MonsterInsights: 8.3.0
Import / Export Customizer Settings: 1.0.5
iThemes Security: 8.0.2
LifterLMS: 5.7.0
LifterLMS Customizations: 1.0.0
LifterLMS Helper: 3.4.1
LifterLMS Labs: 1.6.0
LifterLMS MailChimp Add-on: 3.2.0
LifterLMS Stripe Payment Gateway: 5.4.0
LifterLMS WooCommerce: 2.2.1
Loginizer: 1.6.8
Rank Math SEO: 1.0.80
Really Simple SSL: 5.2.2
Sidebar Manager: 1.1.7
Ultimate Addons for Gutenberg: 1.25.2
UpdraftPlus - Backup/Restore: 1.22.1
W3 Total Cache: 2.2.1
Wicked Folders: 2.18.10
WooCommerce: 6.1.0
WooCommerce Stripe Gateway: 6.0.0
WPForms Lite: 1.7.2
WP Mail SMTP: 3.2.1


Integrations
-------------------------------------------

BbPress: No
BuddyPress: No
WooCommerce: Yes
LifterLMS MailChimp: No


Template Overrides
-------------------------------------------

This issue has been recreated:

Locally
On a staging site
On a production website
With only LifterLMS and a default theme

Browser, Device, and Operating System Information

Browser name and version
Operating System name and version
Device name and version (if applicable)

Related User Information

HS-184968

LifterLMS Labs prevents Beaver Builder from enabling Certificated and Awarded Certificate Post Type integration

Reproduction Steps

Install LifterLMS Labs
Install Beaver Builder Page builder
Enable the Beaver Builder page builder in LifterLMS Labs
Head into Beaver Builder Settings->Post Types
HS-213476

Expected Behavior

Certificates and Awarded certificates should be visible to enable the builder integration

Actual Behavior

With the LifterLMS Labs integration enabled with Beaver Builder the Certificate post types are not an option

Error Messages / Logs

Include any relevant error messages or log files

<!-- Paste error logs / backtraces below this line -->

System and Environment Information

System Report

Wordpress
-------------------------------------------

Home Url: https://natie.myliftersite.com
Site Url: https://natie.myliftersite.com
Login Url: https://natie.myliftersite.com/wp-login.php
Version: 6.1.1
Debug Mode: Yes
Debug Log: Yes
Debug Display: Yes
Locale: en_US
Multisite: No
Page For Posts: Not Set
Page On Front: Not Set
Permalink Structure: /%postname%/
Show On Front: posts
Wp Cron: No


Settings
-------------------------------------------

Version: 7.0.1
Db Version: 7.0.1
Course Catalog: Course Catalog (#120) [https://natie.myliftersite.com/courses/]
Membership Catalog: Membership Catalog (#121) [https://natie.myliftersite.com/memberships/]
Student Dashboard: Dashboard (#123) [https://natie.myliftersite.com/dashboard/]
Checkout Page: Purchase (#122) [https://natie.myliftersite.com/purchase/]
Course Catalog Per Page: 9
Course Catalog Sorting: menu_order,ASC
Membership Catalog Per Page: 9
Membership Catalog Sorting: menu_order
Site Membership: Not Set
Courses Endpoint: my-courses
Edit Endpoint: edit-account
Lost Password Endpoint: lost-password
Vouchers Endpoint: redeem-voucher
Autogenerate Username: no
Password Strength Meter: no
Minimum Password Strength: 
Terms Required: no
Terms Page: Not Set
Checkout Names: 
Checkout Address: 
Checkout Phone: 
Checkout Email Confirmation: no
Open Registration: no
Registration Names: 
Registration Address: 
Registration Phone: 
Registration Voucher: 
Registration Email Confirmation: no
Account Names: 
Account Address: 
Account Phone: 
Account Email Confirmation: no
Confirmation Endpoint: confirm-payment
Force Ssl Checkout: no
Country: US
Currency: MXN
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Decimals: 2
Trim Zero Decimals: no
Recurring Payments: yes
Email From Address: [email protected]
Email From Name: My LifterLMS Trial Site
Email Footer Text: 
Email Header Image: 
Cert Bg Width: 800
Cert Bg Height: 616
Cert Legacy Compat: no


Constants
-------------------------------------------

LLMS_REMOVE_ALL_DATA: undefined
LLMS_REST_DISABLE: undefined
LLMS_SITE_FEATURE_RECURRING_PAYMENTS: undefined
LLMS_SITE_IS_CLONE: undefined


Gateways
-------------------------------------------

Manual: Enabled
Manual Logging: no
Manual Order: 1


Server
-------------------------------------------

Mysql Version: 5.7.41
Php Curl: Yes
Php Default Timezone: UTC
Php Fsockopen: Yes
Php Max Input Vars: 5000
Php Max Upload Size: 512 MB
Php Memory Limit: 256M
Php Post Max Size: 1024M
Php Soap: Yes
Php Suhosin: No
Php Time Limt: 30
Php Version: 8.0.28
Software: Apache/2.4.55 (Unix) OpenSSL/1.1.1
Wp Memory Limit: 256M


Browser
-------------------------------------------

HTTP USER AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/111.0


Theme
-------------------------------------------

Name: Beaver Builder – Child
Version: 1.0
Themeuri: https://www.causelabs.com/
Authoruri: https://www.causelabs.com/
Template: bb-theme
Child Theme: Yes
Llms Support: No


Plugins
-------------------------------------------

Beaver Builder Plugin (Lite Version): 2.6.2.3
LifterLMS: 7.0.1
LifterLMS Labs: 1.6.0
User Switching: 1.7.0


Integrations
-------------------------------------------

BbPress: No
BuddyPress: No


Template Overrides
-------------------------------------------

This issue has been recreated:

Locally
On a staging site
On a production website
With only LifterLMS and a default theme

Browser, Device, and Operating System Information

Browser name and version
Operating System name and version
Device name and version (if applicable)

Activation of the Beaver Builder Lab clears default BB supported post types

Recreation Steps

Install & activate Beaver Builder and don't save/edit/modify any settings
Install & activate Labs plugin
Activate the BB lab
Navigate to BB -> Settings -> Post types

Expected

Pages (bb default), courses, memberships, and lessons should be checked

Actual

Only courses, memberships, and lessons are checked

Cause

The lab uses a default empty array on this line:

lifterlms-labs/inc/labs/class.llms.lab.beaver.builder.php

Line 97 in 0bb89af

$existing = get_option( '_fl_builder_post_types', array() );

This empty array should actually be array( 'page' ) to work the same as the default values in the BB core plugin.

Mini translation lab

Interface for translating key terms like "Course" "Lesson" "Section" etc...

Update to Remove Alert Message

Update LiffterLMS so as to not have this alert message:

This plugin hasn’t been tested with the latest 3 major releases of WordPress. It may no longer be maintained or supported and may have compatibility issues when used with more recent versions of WordPress.

Lifti: Divi predefined layout appears to no longer function

PHP8 and WP5.6 Compat

Add-on Checklist

Composer Updates
- lifterlms/lifterlms-tests
  - Switch from "dev-master" to "dev-trunk"
  - Update to latest version
- lifterlms/lifterlms-cs
  - Switch from "dev-master" to "dev-trunk"
  - Update to latest version
- Scripts
  - Update scripts to match the LifterLMS Core scripts block
  - Ensure any custom scripts are retained
  - Ensure database scripts use a custom default database name, eg "llms_groups_tests" instead of "llms_tests"
  - If the add-on is not configured for E2E testing the "env" and "env:setup" commands can be removed
- PHP Requirements
  - Update PHP version to be >=7.2
Travis Config Updates
- Update to import the add-on.yml config from the LLMS core.
- Import the e2e config if the add-on is setup for e2e testing
- Retain any custom jobs specific to the add-on
Tests
- Test Suite Passes in Travis
- Passes manual inspection on php8

Beaver Builder compatibility: node visibility based on the user's enrollment status doesn't work as expected

hs # 110026

Reproduction Steps

Create a course A
Create a course B
Create a course C
Create a user U
Enroll the user U in C
Create a page with the Beaver Builder, and add 2 nodes
For the first node set the Visibility Display & co. properties (under Advanced) as Enrolled Students in Specific Course(s) and/or Membership(s) Match Any of the following Courses Course A, Course B
For the second node set the Visibility Display & co. properties (under Advanced) as Non-Enrolled Students and Visitors in Specific Course(s) and/or Membership(s) Match Any of the following Courses Course C
Visit the just created page logged-in as U

Expected Behavior

I would expect to not see any node

Actual Behavior

I see both the aforementioned nodes

Error Messages / Logs

n/a

System Information

Beaver Builder 2.3.1.1
LifterLMS 3.37.8
LifterLMS Labs 1.5.2

Browser, Device, and Operating System Information

n/a

The issue is in this piece of code:
https://github.com/gocodebox/lifterlms-labs/blob/1.5.2/inc/labs/class.llms.lab.beaver.builder.php#L288-L334

You know what? Unit tests here would help a lot :D
Please let me know if you want me adding tests (and the tests suite of course). Didn't do it in the PR as I don't know whether or not this can be considered as a priority.

Action Manager Settings not saving

Reproduction Steps

HS-170429

Install LifterLMS Labs
Go into Action Manager and check some settings
Save
refresh or click to another screen and come back to action manager

-- Rocco did explain to me why Action Manager doesn't work with Gutenberg since the blocks aren't hooks so this doesn't necessarily help the customer but I also noticed it was not saving with Classic Editor either.

Expected Behavior

The settings should save and at least take affect on classic editor course/lesson content

Actual Behavior

the settings themselves in action manager aren't saving

Error Messages / Logs

Include any relevant error messages or log files

<!-- Paste error logs / backtraces below this line -->

System and Environment Information

System Report

Wordpress
-------------------------------------------

Home Url: https://natalie-5-testing.myliftersite.com
Site Url: https://natalie-5-testing.myliftersite.com
Login Url: https://natalie-5-testing.myliftersite.com/wp-login.php
Version: 5.7.2
Debug Mode: Yes
Debug Log: Yes
Debug Display: Yes
Locale: en_US
Multisite: No
Page For Posts: Not Set
Page On Front: Homepage (#155) [https://natalie-5-testing.myliftersite.com/]
Permalink Structure: /%postname%/
Show On Front: page
Wp Cron: Yes


Settings
-------------------------------------------

Version: 5.0.2
Db Version: 5.0.2
Course Catalog: Course Catalog (#9) [https://natalie-5-testing.myliftersite.com/courses/]
Membership Catalog: Membership Catalog (#10) [https://natalie-5-testing.myliftersite.com/memberships/]
Student Dashboard: Student Dashboard (#12) [https://natalie-5-testing.myliftersite.com/dashboard/]
Checkout Page: Purchase (#11) [https://natalie-5-testing.myliftersite.com/purchase/]
Course Catalog Per Page: -1
Course Catalog Sorting: menu_order,ASC
Membership Catalog Per Page: 9
Membership Catalog Sorting: menu_order,ASC
Site Membership: Not Set
Courses Endpoint: my-courses
Edit Endpoint: edit-account
Lost Password Endpoint: lost-password
Vouchers Endpoint: redeem-voucher
Autogenerate Username: no
Password Strength Meter: no
Minimum Password Strength: 
Terms Required: yes
Terms Page: Block Content Examples (#156) [https://natalie-5-testing.myliftersite.com/block-content-examples/]
Checkout Names: 
Checkout Address: 
Checkout Phone: 
Checkout Email Confirmation: no
Open Registration: yes
Registration Names: 
Registration Address: 
Registration Phone: 
Registration Voucher: 
Registration Email Confirmation: no
Account Names: 
Account Address: 
Account Phone: 
Account Email Confirmation: no
Confirmation Endpoint: confirm-payment
Force Ssl Checkout: no
Country: SA
Currency: EUR
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Decimals: 2
Trim Zero Decimals: no
Recurring Payments: yes
Email From Address: [email protected]
Email From Name: A LifterLMS Sandbox
Email Footer Text: 
Email Header Image: 
Cert Bg Width: 800
Cert Bg Height: 616
Cert Legacy Compat: no


Constants
-------------------------------------------

LLMS_REMOVE_ALL_DATA: undefined
LLMS_REST_DISABLE: undefined
LLMS_SITE_FEATURE_RECURRING_PAYMENTS: undefined
LLMS_SITE_IS_CLONE: undefined


Gateways
-------------------------------------------

Manual: Enabled
Manual Logging: no
Manual Order: 1


Server
-------------------------------------------

Mysql Version: 5.7.34
Php Curl: Yes
Php Default Timezone: UTC
Php Fsockopen: Yes
Php Max Input Vars: 5000
Php Max Upload Size: 512 MB
Php Memory Limit: 256M
Php Post Max Size: 1024M
Php Soap: Yes
Php Suhosin: No
Php Time Limt: 30
Php Version: 7.3.29
Software: Apache/2.4.48 (Unix) OpenSSL/1.1.1
Wp Memory Limit: 256M


Browser
-------------------------------------------

HTTP USER AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36


Theme
-------------------------------------------

Name: Astra
Version: 3.6.4
Themeuri: https://wpastra.com/
Authoruri: https://wpastra.com/about/
Template: 
Child Theme: No
Llms Support: Yes


Plugins
-------------------------------------------

Classic Editor: 1.6
LifterLMS: 5.0.2
LifterLMS Advanced Videos: 1.0.0-beta.14
LifterLMS Labs: 1.5.3
LifterLMS Private Areas: 1.1.4
LifterLMS WooCommerce: 2.1.3


Integrations
-------------------------------------------

BbPress: No
BuddyPress: No
WooCommerce: No
LifterLMS Private Areas: Yes
Videos: Vimeo: Yes
Videos: Wistia: No
Videos: YouTube: No


Template Overrides
-------------------------------------------

This issue has be recreated:

Locally
[] On a staging site
On a production website
With only LifterLMS and a default theme

Browser, Device, and Operating System Information

Browser name and version
Operating System name and version
Device name and version (if applicable)

Lifti: custom module classes for enrolled/non-enrolled don't work on lessons

This would only be an issue when using free lessons if you're trying to hide some content from non-enrolled students when viewing a free lesson

gocodebox / lifterlms-labs Goto Github PK

lifterlms-labs's People

Contributors

Stargazers

Watchers

Forkers

lifterlms-labs's Issues

Reproduction Steps

Expected Result

Actual Result

Error Log

System Info

Reproduction Steps

Expected Behavior

Actual Behavior

Error Messages / Logs

System and Environment Information

This issue has been recreated:

Browser, Device, and Operating System Information

Related User Information

Reproduction Steps

Expected Behavior

Actual Behavior

Error Messages / Logs

System and Environment Information

This issue has been recreated:

Browser, Device, and Operating System Information

Recreation Steps

Expected

Actual

Cause

Reproduction Steps

Expected Behavior

Actual Behavior

Error Messages / Logs

System Information

Browser, Device, and Operating System Information

Reproduction Steps

Expected Behavior

Actual Behavior

Error Messages / Logs

System and Environment Information

Browser, Device, and Operating System Information

Recommend Projects

Recommend Topics

Recommend Org