Comments (14)
I generally agree on never keeping anything that's not source code into the repository.
What I've understood is that bindata.go is there to allow for "go get" to get you a compiled binary, so basically a workaround to a "go get" limitation. But I don't have further references about this limitation and other possible workarounds.
In all cases, I think it is acceptable to go get ...; less README.md; make;
from gitea.
I don't agree on that. There are no other ways to stay go gettable than adding bindata to the repo.
If there are other ways around we can talk about that.
from gitea.
BTW, go get will fail without the bindata because the imports can't be accomplished
from gitea.
@tboerger it will fail but will have downloaded all the sources, right ?
from gitea.
But if I go get something I expect to have it working without reading the readme to find out what else needs to be done
from gitea.
I'm not a long Go user enough to know what one would have to expect by "go get". I've read it's not a package manager, but I do see it being used as such
from gitea.
For the PR mess (conflicts and changelogs size), I shall note that @unkwon used to only update bindata.go before releases, and not accepting those updates in the PRs themselves.
from gitea.
I would suggest an additional commit made by the CI system that updates the bindata.
from gitea.
If bindata.go has to stay, +1 for the CI system automation (only if it would change).
But I'd really prefer to give-up go-get'ability than keeping generated files in the repo.
How about making bindata.go usage optional, so to retain go-getability while still allowing bindata.go usage upon request ?
from gitea.
@tboerger is the optional bindata.go what you'd get with build tags ? (#74 (comment))
from gitea.
My take on the optional embedding of files is in this PR: #78
I've understood @tboerger is also working on making embedding optional in his #74, but I think that PR also adds public
and templates
into the bindata, so maybe it make sense to divide the work in two steps, for easier reviews ?
from gitea.
For reference, @tboerger PR about conditional bindata embedding is #30 (came out in gitter chat)
from gitea.
So, should this be closed as a duplicate of #30 ?
from gitea.
Duplicate of #30
from gitea.
Related Issues (20)
- Tag name rules
- Sort tags by commit date
- Add `refs/pull/1/merge` reference for pull request to avoid the merged commit id missed.
- Debian Package Registry: duplicate key value violates unique constraint "UQE_package_version_s" HOT 1
- SIGSEGV when pushing sha256 repository HOT 8
- home page title overflow
- Gogs migration tool HOT 3
- Revise server side hook configuration to support dynamic hook file extensions. HOT 2
- Merged PR should hidden time tracker? HOT 1
- No operation for a long time, no response HOT 2
- Data race during testing HOT 3
- Option to skip issue details in /times endpoints reply HOT 1
- Server misbehaving when trying to push/pull/login to docker registry HOT 16
- Conan: invalid literal for int() with base 10: '' HOT 2
- Render xlsx same as docx HOT 2
- Difference between github and gitea actions when running contains(needs.*.result, 'success')
- Add a more obvious approve button for MRs HOT 2
- Support itch.io OAuth2 provider HOT 6
- Large uploads fail in web client HOT 3
- Deleted branch still visible in branch list and 404 on access HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitea.