SIGSEGV when pushing sha256 repository about gitea HOT 8 CLOSED

I don't see this error in main branch, so it's fixed there.

from gitea.

I did some following up fixes like #30877 (and it has been backported)

could you try 1.22 nightly?

from gitea.

Where is the 1.22 nightly?

The change looks like version checks only which should not be an issue. But I'll find what fixed it :-)

from gitea.

Gitea in release/v1.22 seems to work.

from gitea.

Where is the 1.22 nightly?

Get 1.22 nightly:

• https://hub.docker.com/r/gitea/gitea/tags?page=&page_size=&ordering=&name=1.22-nightly
• https://dl.gitea.com/gitea/1.22/ ( @techknowlogick would you like to rename it to 1.22-nightly for consistency?)

Gitea in release/v1.22 seems to work.

Yup, I think it has been fixed by the way.

from gitea.

Gitea in release/v1.22 seems to work.

So I guess this issue could be closed as completed? 🤔

from gitea.

I did some following up fixes like #30877 (and it has been backported)

Confirmed, it's fixed by this PR. Thanks!

from gitea.

Just to add some background here as to the reason this was happening, if someone else stumbles on this here,

1. sha256 support is conditional on newer git tools version
2. this check is run as part of InitFull() but not part of InitSimple()
3. InitSimple() was only run when gitea commands/hooks are run.
4. The patch mentioned above checks the git version always, not just in the main process.
5. CommitID parser doesn't have an error handler in this codepath hence SIGSEGV.

from gitea.