Git Product home page Git Product logo

Comments (12)

gmarcais avatar gmarcais commented on September 2, 2024

Indeed, that is not good. I'll fix it ASAP.

from jellyfish.

gmarcais avatar gmarcais commented on September 2, 2024

Can you try the develop branch? The issue should be fixed.

from jellyfish.

rob-p avatar rob-p commented on September 2, 2024

That was fast! I'll test it out as soon as I get into work.

from jellyfish.

rob-p avatar rob-p commented on September 2, 2024

Here I betray my strong CMake bias — what magical invocations must I make to generate a proper configure script? I tried aclocal && autoconf && automake --add-missing.

from jellyfish.

gmarcais avatar gmarcais commented on September 2, 2024

The magic call is:

echo abracadabra; autoreconf -fi

from jellyfish.

rob-p avatar rob-p commented on September 2, 2024

ahhh, see I was missing the abracadabra incantation! Any interest in building a tagged tarball (i.e. with a stable GitHub url) that already has the ./configure script ready to go? Right now I'm pulling from https://github.com/gmarcais/Jellyfish/archive/develop.zip , which, I imagine, is subject to change in content ;P.

from jellyfish.

gmarcais avatar gmarcais commented on September 2, 2024

I will do that. I was hoping to get a feed back from you that it indeed fixed the problem before generating a new version and upload it to the releases.

from jellyfish.

rob-p avatar rob-p commented on September 2, 2024

I can confirm that this does, indeed, fix the problem (using Rory's test data). The parser now returns (and RapMap now reports) having observed 5 reads, instead of 0, which is correct.

from jellyfish.

gmarcais avatar gmarcais commented on September 2, 2024

OK, the new distribution tarball is ready in the releases(https://github.com/gmarcais/Jellyfish/releases).

Thanks for the bug report.

from jellyfish.

rob-p avatar rob-p commented on September 2, 2024

Fantastic. Thanks, Guillaume!

from jellyfish.

roryk avatar roryk commented on September 2, 2024

Thanks!

from jellyfish.

mr-c avatar mr-c commented on September 2, 2024

Is it known how far back this bug has existed?

from jellyfish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.