glankk / libgfxd Goto Github PK

Running valgrind shows these errors:
==20160== Source and destination overlap in memcpy_chk(0x416818, 0x4169d0, 3520) ==20160== at 0x4A4A310: __memcpy_chk (vg_replace_strmem.c:1617) ==20160== by 0x376BDF: memmove (string_fortified.h:36) ==20160== by 0x376BDF: gfxd_execute (gfxd.c:746) ==20160== by 0x2B968D: ZDisplayList::ProcessGfxDis(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (in /home/louist103/decomp/oot/tools/ZAPD/ZAPD.out) ==20160== by 0x2B7B5B: ZDisplayList::GetSourceOutputCode(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (in /home/louist103/decomp/oot/tools/ZAPD/ZAPD.out) ==20160== by 0x2CAA95: ZFile::GenerateSourceFiles(std::filesystem::__cxx11::path) (in /home/louist103/decomp/oot/tools/ZAPD/ZAPD.out) ==20160== by 0x2C8C17: ZFile::ExtractResources() (in /home/louist103/decomp/oot/tools/ZAPD/ZAPD.out)

I'd like to be able to run libgfxd without invoking callbacks. I think a setting that just enables/disables them would be nice and simple.

I'll attempt to implement this myself. Just making the issue for the sake of organization / discussion if that's relevant.

I'd like to be able to allocate just enough space for my output buffer, and from a discussion in discord, it seems a standard way to do this is to run the code once, collecting the number of bytes required, and then to return that information to the user to run it again, supplying a buffer of the specified size.

The invocation to calculate the number of bytes should avoid using any callbacks.