gkindel / csv-js Goto Github PK

Have you considered adding serialization from JS to CSV to this library?

I'd like to run this through a linter (fix == vs === ambiguities, missing semicolons, and a few other inconsistencies) and then publish it to npm.

Any objection?

The repo description links to http://gkindel.github.io/cxv-js/csv.html when it should probably point to http://gkindel.github.io/csv-js/csv.html

I'm using this lib as a bower dependency and commits pushed today have broken AMD support.
Problem is now i can't easily force a specific working version since the repo does not contain proper tags.

Please add tags and bump version number in bower.json accordingly.

When trying to use this library in a React project with Webpack, it fails to build and gives the following error:

229:20-27 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

The problem seems to be the way require is being used in CSV.stream and CSV.stream.json functions. For my use case, I only required the parse method so I have commented these parts of the code and everything works fine.

not sure why the following doesn't work. seems valid

CSV.parse("fruit, frozen dessert, "C00,$$$,000", """"candy, het""""")

would add an option for parse which would indicate that the values for row 0 should be used as keys for parsing all other values

maybe along with ok.js too, since it's a devDependency

add a flexibility setting for allowing values such as "1,234.56" to be typed as numbers

Hello Greg,
can I suggest to add this great project to the bower components?

Thanks

Hi,

I'm having an issue with commas enclosed inside quotes. The string is separated at the commas and treated as separate fields. According to the spec this shouldn't happen.

Example:

"one", "number two", 3
"two one", "number, two two ", 2.3

Would fail because of the comma in the quoted string in the second line

Hi

Thanks for making csv-js

Nordic versions of ms excel and friends uses ; as separator because , is used for decimals rather than . as in us (which if you ask me as a programmer, is stupid) :)

What do you think of allowing customization of which separator to use?

Thanks

When the CSV has lines that are separated by a single CR, it does not seem to handle them correctly. Instead of detecting it as the end of line, it keeps parsing the start of the next token on the next line as part of the last token on the previous line.

Can a license file be added? I'm evaluating different tools for parsing CSV strings and have found this straightforward to use and appreciate the confidence that the test cases bring. I find this code useful, but we technically cannot use it for work purposes because it has no license file: https://opensource.stackexchange.com/questions/1720/what-can-i-assume-if-a-publicly-published-project-has-no-license/1721#1721

Thanks a lot for your parser. I took a look at the code and am under the impression that changing the delimiter takes more than changing this one setting. Is this correct? It would be nice to specify the delimiter, so we could also use this for tsv's