Git Product home page Git Product logo

libf's Issues

fseq.cpp doesn't compile with g++

I fully understand you're targeting clang++ but everything else compiles with g++ -std=c++17 -fno-exceptions -fno-rtti -nodefaultlibs -fPIC -O2 -c -o ...

g++ (version 8.3.0) dislikes some templates:

fseq.cpp:830:26: error: could not convert ‘ss.F::_SeqSingle::t[0]’ from ‘const Tree’ {aka ‘const F::Union<F::_Boxed<F::_FragHeader>, F::Tree2, F::Tree3>’} to ‘F::Frag’ {aka ‘F::_Boxed<F::_FragHeader>’}
             return ss.t[0];

etc. Maybe it's just a case of selecting the right field in the union? It should return the first one, I guess? Or is it that the const qualifier is dropped? I found the definition of Union in fvalue.h but it's not obvious to me how it works yet.

Maybe you don't mind about g++ compatibility, but it would certainly increase your user-base among those for whom it's not easy to install clang.

Use of 2-3 Finger Trees

Hi.

I couldn't find any forum, discussion group or eMail-Address, hence I allowed myself to ask this question here.

While looking for an implementation of finger trees in C++, I came across libf. Using the implementation of 23-fingertrees underlying the sequence type, is it possible to annotate each node with a measure?

More concretely, what I'm trying to do is very similar to this: http://jkff.info/articles/ire/

many thanks.

Underscore misuse

The current code-base uses underscore prefixes for the names of "hidden" definitions. Although this seems to build OK with my version of clang, redditor Yuushi points out:

As a nitpick, the usage of _ before every variable is a worry, though. C++ reserves any name starting with _ and followed by a capital letter.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.