Git Product home page Git Product logo

dragonloot's People

Contributors

enterfor avatar fitfc avatar gitpois1x avatar gliscowo avatar globox1997 avatar gyular avatar lorddeathunter avatar mpustovoi avatar nitjsefnie avatar rawpineapple avatar yavental avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

dragonloot's Issues

Consider using FallFlyingLib?

Hi, I'm a fellow Fabric mod developer and author of https://github.com/CafeteriaGuild/FallFlyingLib

Would you consider using FallFlyingLib instead of Mixin-ing into the entities?

FallFlyingLib exists to make sure mods don't clash by mixin-ing into the tiny LivingEntity#initAi method. (Been there, done that)
I tried to make it flexible yet simple enough for everyone.

Someone asked in my guild for compatibility between FallFlyingLib-based mods and DragonLoot, so I figured I might as well ask!

[SUGGESTION] Add an advancement

This mod itself is really great, but to match the end theme there should be an advancement somewhat similar to cover me in debris that says "The Armor at The End of The Game

Remove damage thing from dragon horse armor

The dragon horse armor has a damage thing, which vanilla horse armor doesn't. It kinda bothers me since I use TillItBreaks mod, that shows durability of things that have the said durability and it's annoying to see durability on thing that isn't supposed to break

Amethyst treats Dragon tools as nonplayer mined

MC 1.18.2
Fabric API 0.51.1
Cloth Config 6.2.62
DragonLoot 1.0.10

To reproduce:

  1. Get a Dragon Pickaxe and a bunch of amethyst clusters
  2. Enchant your pickaxe with Fortune 3; place the clusters down anywhere you want
  3. Break the clusters with your enchanted pickaxe

Expected result: amethyst shards drop in quantities of 4-16, calculated depending on the level of Fortune.

Actual result: amethyst shards drop in quantities of exactly 2, which should not be possible at all when the cluster is broken directly by a player.

Logs: https://gist.github.com/Footage2-Amply-Pounce/1d5cb548163e9f0321da1c6a16131b05

[suggestion] config file

It would be really useful if you could make a config file where we could change the stats of the armour and the number of scales that drop from killing the ender dragon so people could balance the armour themselves, it would also stop a lot of people from complaining

Damage

Hello, I wanna to change the damage of the Dragon Scale items, because it have a incredible texture and is so much hard to get than the swords of other Mods, I don't know how or where I need to go for editing this, I look for the json file and I only find the durability and armor defense editing text

It crashes my game

I am using fabric 1.16.4, and when I try to load version 1.0.3 of this mod, my game crashes. It says error code 0, meaning it was an unknown crash. This only happens whenever I load this mod. I have no idea why, and I was not provided with a crash report.

Fatal Error

Mixin apply failed dragonloot.mixins.json:AnvilScreenHandlerMixin -> net.minecraft.class_1706: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException InjectionPoint(Shift)[@at("INVOKE")] on net/minecraft/class_1706::updateResultMixin with priority 1000 cannot inject into net/minecraft/class_1706::method_24928()V merged by cn.enaium.noexpensive.mixin.AnvilScreenHandlerMixin with priority 1000 [PREINJECT Applicator Phase -> dragonloot.mixins.json:AnvilScreenHandlerMixin -> Prepare Injections -> -> handler$znj000$updateResultMixin(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Prepare]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: InjectionPoint(Shift)[@at("INVOKE")] on net/minecraft/class_1706::updateResultMixin with priority 1000 cannot inject into net/minecraft/class_1706::method_24928()V merged by cn.enaium.noexpensive.mixin.AnvilScreenHandlerMixin with priority 1000 [PREINJECT Applicator Phase -> dragonloot.mixins.json:AnvilScreenHandlerMixin -> Prepare Injections -> -> handler$znj000$updateResultMixin(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Prepare]
at org.spongepowered.asm.mixin.injection.code.Injector.findTargetNodes(Injector.java:293)
at org.spongepowered.asm.mixin.injection.code.Injector.find(Injector.java:240)
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.prepare(InjectionInfo.java:375)
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1255)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1033)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:388)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:320)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:345)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:569)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:351)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:208)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:178)
at org.spongepowered.asm.mixin.transformer.FabricMixinTransformerProxy.transformClassBytes(FabricMixinTransformerProxy.java:23)
at net.fabricmc.loader.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:157)
at net.fabricmc.loader.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:150)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at net.minecraft.class_2246.(class_2246.java:426)
at net.minecraft.class_3523.(class_3523.java:13)
at net.minecraft.class_5471.(class_5471.java:11)
at net.minecraft.class_5458.method_30573(class_5458.java:44)
at net.minecraft.class_5458$$Lambda$232/844133497.get(Unknown Source)
at net.minecraft.class_5458.method_30566(class_5458.java:75)
at net.minecraft.class_5458$$Lambda$240/16957838.accept(Unknown Source)
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:676)
at net.minecraft.class_5458.(class_5458.java:74)
at net.minecraft.class_2378.(class_2378.java:237)
at io.github.cottonmc.jankson.JanksonFactory.builder(JanksonFactory.java:85)
at io.github.cottonmc.jankson.JanksonFactory.createJankson(JanksonFactory.java:159)
at io.github.redstoneparadox.paradoxconfig.serialization.jankson.JanksonConfigSerializer.(JanksonConfigSerializer.java:16)
at io.github.redstoneparadox.nicetohave.config.Config.(Config.java:13)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)
at io.github.redstoneparadox.paradoxconfig.util.ReflectionUtil.getClassForName(ReflectionUtil.java:13)
at io.github.redstoneparadox.paradoxconfig.ParadoxConfig.initConfigs$paradox_config(ParadoxConfig.java:66)
at io.github.redstoneparadox.paradoxconfig.ParadoxConfig.onPreLaunch(ParadoxConfig.java:21)
at net.fabricmc.loader.launch.knot.Knot$$Lambda$88/1961595039.accept(Unknown Source)
at net.fabricmc.loader.entrypoint.minecraft.hooks.EntrypointUtils.invoke0(EntrypointUtils.java:50)
at net.fabricmc.loader.entrypoint.minecraft.hooks.EntrypointUtils.invoke(EntrypointUtils.java:36)
at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:139)
at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:27)

Anvil breaks when dropped

Description:

The Dragon anvil works exactly like a notmal
anvil, but it never breaks

It breaks completely when it is thrown from a high place, intended behavior?

Other Mod Incompatibilities

Is there a way of fixing this issue, basically, my dragon pickaxe doesnt work on any ores added by any other mod which i thought wouldnt be an issue, like i thought there would just be a certain power needed to break each one, but it doesnt work like that i suppose, I'd also assume the same goes for the axe and shovel, i assume it will have normal fist breaking speed for anything added by another mod

Crash when accessing REI page with DragonLoot items

Title basically says everything there is to say. Here is the full crash log: https://bin.s.nachtalb.io/wociwayowe.txt

Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1309.method_6014()" because "livingEntity" is null
 	at net.dragonloot.init.ModelProviderInit.lambda$init$0(ModelProviderInit.java:15) ~[dragonloot-1.0.7.jar:?]

If you need any more information please tell me :) Haven't used the mod yet but looks nice from what I see on curseforge ๐Ÿ‘

Dragon Scales

Is there a way to get more dragon scales? I just killed the dragon and he didn't give me more dragon scales?

[Suggestion] Anvil Config

Can you add a config for the Dragon anvil? Love the idea to override the limit but would like to disable the 30 levels cap.

Odd explosion mechanics

dragonloot v1.0.10

most of the dropped items don't explode by creepers/TNT except for:

  1. dragon anvil
  2. dragon horse armor
  3. dragon trident

is this intended? they ALWAYS explode.

Help

I wanna change the durability of everything because the enderite mod is better and this looks cooler so I would like to raise the durability of the items so it's more powerful than the enderite, where can i find that, I checked in items and stuff but didn't find it

better end support (suggestion) (its me from the curseforge page named "mykidneypopped")

if you can, make it so the better end tools and armour works with this. maybe since there's 2 types(better than netherite), you can only do it with one, and if you decide to make it so it works for both sets maybe the scales do different things for each set? for crystallite maybe it just like most mods, raises protection and toughness (and durability) but for the Aternium you get, say well for one, like the netherite, you can combine the ARMOURED ELYTRA, not a normal or crystallite one, with a Aternium chestplate, but you cant combine the crystallite chestplate with the elytra? and then the Aternium also gains say, a single, not too overpowered effect, say 1 more heart? i think what ive said is a bit too op, but its up to you if you decide to add this.

Weird crash

[23:34:24] [main/FATAL]: Unreported exception thrown!
org.spongepowered.asm.mixin.injection.callback.CancellationException: The call method_17369 is not cancellable.
	at Not Enough Crashes deobfuscated stack trace.(1.16.4+build.7) ~[?:?]
	at org.spongepowered.asm.mixin.injection.callback.CallbackInfo.cancel(CallbackInfo.java:101) ~[sponge-mixin-0.8.2+build.24.jar:0.8.2+build.24+unknown-b24.git-unknown]
	at org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable.setReturnValue(CallbackInfoReturnable.java:106) ~[sponge-mixin-0.8.2+build.24.jar:0.8.2+build.24+unknown-b24.git-unknown]
	at net.minecraft.screen.AnvilScreenHandler.handler$bem000$getLevelCostMixin(AnvilScreenHandler:1075) ~[?:?]
	at net.minecraft.screen.AnvilScreenHandler.getLevelCost(AnvilScreenHandler) ~[?:?]
	at net.minecraft.client.gui.screen.ingame.AnvilScreen.handler$fag001$drawForeground(AnvilScreen:2531) ~[?:?]
	at net.minecraft.client.gui.screen.ingame.AnvilScreen.drawForeground(AnvilScreen) ~[?:?]
	at net.minecraft.client.gui.screen.ingame.HandledScreen.render(HandledScreen:142) ~[?:?]
	at net.minecraft.client.gui.screen.ingame.ForgingScreen.render(ForgingScreen:42) ~[?:?]
	at net.minecraft.client.render.GameRenderer.render(GameRenderer:616) ~[?:?]
	at net.minecraft.client.MinecraftClient.render(MinecraftClient:1048) ~[?:?]
	at net.minecraft.client.MinecraftClient.run(MinecraftClient:681) ~[?:?]
	at net.minecraft.client.MinecraftClient.handler$bjd000$afterCrashHandled(MinecraftClient:12404) ~[?:?]
	at net.minecraft.client.MinecraftClient.run(MinecraftClient:699) ~[?:?]
	at net.minecraft.client.main.Main.main(Main:215) [intermediary-minecraft-1.16.4-client.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_271]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_271]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_271]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_271]
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:226) [fabric-loader-0.11.1.jar:?]
	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:139) [fabric-loader-0.11.1.jar:?]
	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:27) [fabric-loader-0.11.1.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_271]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_271]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_271]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_271]
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196) [NewLaunch.jar:?]
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?]
[23:34:24] [main/FATAL]: Minecraft ran into a problem! Report saved to: C:\Users\Seba\Desktop\Gry\MultiMC\instances\Fabulously-Optimized-1.4.2\minecraft\crash-reports\crash-2021-01-20_23.34.24-client.txt
---- Minecraft Crash Report ----
// I bet Cylons wouldn't have this problem.

Time: 2021-01-20 23:34:24 CET
Description: Rendering screen

org.spongepowered.asm.mixin.injection.callback.CancellationException: The call method_17369 is not cancellable.
    at Not Enough Crashes deobfuscated stack trace.(1.16.4+build.7)
    at org.spongepowered.asm.mixin.injection.callback.CallbackInfo.cancel(CallbackInfo.java:101)
    at org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable.setReturnValue(CallbackInfoReturnable.java:106)
    at net.minecraft.screen.AnvilScreenHandler.handler$bem000$getLevelCostMixin(AnvilScreenHandler:1075)
    at net.minecraft.screen.AnvilScreenHandler.getLevelCost(AnvilScreenHandler)
    at net.minecraft.client.gui.screen.ingame.AnvilScreen.handler$fag001$drawForeground(AnvilScreen:2531)
    at net.minecraft.client.gui.screen.ingame.AnvilScreen.drawForeground(AnvilScreen)
    at net.minecraft.client.gui.screen.ingame.HandledScreen.render(HandledScreen:142)
    at net.minecraft.client.gui.screen.ingame.ForgingScreen.render(ForgingScreen:42)
    at net.minecraft.client.render.GameRenderer.render(GameRenderer:616)
    at net.minecraft.client.MinecraftClient.render(MinecraftClient:1048)
    at net.minecraft.client.MinecraftClient.run(MinecraftClient:681)
    at net.minecraft.client.MinecraftClient.handler$bjd000$afterCrashHandled(MinecraftClient:12404)
    at net.minecraft.client.MinecraftClient.run(MinecraftClient:699)
    at net.minecraft.client.main.Main.main(Main:215)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:226)
    at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:139)
    at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:27)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
    at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
    at org.multimc.EntryPoint.listen(EntryPoint.java:143)
    at org.multimc.EntryPoint.main(EntryPoint.java:34)

To reproduce, try to enchant something needing more than 30 levels in Dragon Anvil.
Using Fair Enchanting mod, idk if it could be conflicting

This Mod is very Unbalanced

  1. This mod makes the elytra completely useless

    • you should have to combine an elytra with the dragon scale chestplate or craft a dragon scale elytra then combine it with a
      dragon scale chestplate
    • also the fact that using the elytra doesn't use any durability is kind of op
  2. the fact that you kill the dragon once and you have all the scales you will ever need is broken

    • you should have to craft the scales into another item which you use to upgrade the armor (like how netherite works)

Recipes missing from game despite items working

I am able to grab the items this mod adds from the creative menu, and the dragon drops scales, but I cannot use any of the recipes to create the items. They are missing from the recipe book and if I place the items in a crafting bench myself, no result is shown. This also applies to the Dragon Anvil, I cannot upgrade armour with it. I have tried using "/recipe give" to give myself the recipes but it said "No new recipes were learned". I also tried removing and adding the recipes from myself and that didn't work either.

Dragon Loot 1.17 Latest Version

Not sure if other mods could be affecting it but in my Better Minecraft FABRIC pack when you first get any item like wood or dirt you instantly get the achievement of dragon loot, some other developer mentioned that they changed the advancements in 1.17.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.