Comments (5)
You can add npm run format
, which runs tsfmt
to your pre-commit hooks if you want.
from vscode-codeql.
I don't have strong feelings about enforcing formatting, I just look at diffs with whitespace changes hidden.
from vscode-codeql.
Ah, I see, admittedly tsfmt
is a bit buggy on jsx
, which I see now is what prompted this issue. Shrug.
from vscode-codeql.
eslint and prettier are now the preferred way of linting and formatting typescript. I think it's something worth looking into. I'm less concerned about what the rules are than just that we are enforcing consistency across the project.
https://www.robertcooper.me/using-eslint-and-prettier-in-a-typescript-project
I'm not saying that we must use them, but only that these tools have a log of options, configuration, and community behind them.
from vscode-codeql.
OK...my change uses mostly default linting options. It makes a few things slightly more lenient, though there are still lots of small things that need to be fixed. For now, I'm thinking that we don't try to fix everything at once. and only fix a file when you're editing it for some other reason as part of another PR. Eventually, we should get to a point where we can add a lint step to the build process.
from vscode-codeql.
Related Issues (20)
- Don't display quick evaluation query runs in the history by default HOT 2
- Crash when CodeQL evaluator log summary is too large HOT 2
- Keep activating the extension ... bug HOT 5
- Error running query: Pending response rejected since connection got disposed (codeQL.runQueryContextEditor) HOT 16
- Warning precedes error in reason why execution failed HOT 1
- Add `codeql` executable to PATH of VS Code Terminal HOT 2
- mac m1 view AST 报错 HOT 1
- The plugin button does not work HOT 2
- Database download gets stuck on connection issues HOT 1
- CodeQL model editor: Support adding additional flows to already modeled methods HOT 1
- [email protected] HOT 1
- [email protected] HOT 1
- [email protected] HOT 1
- Creating skeleton query pack logs error HOT 1
- Creating skeleton query pack shows spurious CodeQL compilation errors HOT 2
- Failed to run query: Database is not registered HOT 1
- CLI test failure HOT 3
- Compiler warning overwrites failing test results in test results pane HOT 3
- CLI test failure HOT 3
- CLI test failure HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-codeql.