Git Product home page Git Product logo

Comments (16)

Sim4n6 avatar Sim4n6 commented on July 17, 2024 1

Go query was run successfully one time in the remote setup previously mentioned. The ruby query run failed twice.
I thought it was because, during the query running, I fired a local terminal ssh connection to the same instance.... I am still investigating on my side.

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024 1

It is definitely related to some limiting factor either instance CPU overload or instance bandwidth limitation.

Check this case in Github Codespace:

Capture d'écran 2023-10-17 181457

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024 1

It is this ruby ql query https://github.com/github/codeql/pull/12992/files#diff-8c993937eef8b8df6969f780265e623d0231fa9c9e1d819f0c66ab9ccc984e89

On a database generated from https://github.com/shirasagi/shirasagi commit f249ce3f06f6bfbc0017b38f5c13de424334c3ea

The source is set to any(DataFlow::Node n) and state ...

PS: I remain available for further details.

from vscode-codeql.

MathiasVP avatar MathiasVP commented on July 17, 2024 1

The source is set to any(DataFlow::Node n) and state ...

That is most likely what's going wrong. Setting your source to be any node in the database will never work on any database larger than a "hello world" project since that will make CodeQL follow dataflow starting at all dataflow nodes in the entire database.

So you need to restrict your isSource somehow. You can read more about how to write a dataflow query at https://codeql.github.com/docs/codeql-language-guides/analyzing-data-flow-in-ruby/#.

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024 1

sure, no problem.

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024

Can this be related to an unstable internet connection?

from vscode-codeql.

charisk avatar charisk commented on July 17, 2024

Hi @Sim4n6, thanks for filing a bug!

Can this be related to an unstable internet connection?

Possibly.. Does the issue come up all the time or is it transient?

I've tested the flow in a Codespace which uses remote host functionality and I was able to run a CodeQL query successfully, but that doesn't exactly replicate your setup

In general, it seems like we have a couple of issues around working with a remote host so I'm not sure of the state of things:

I'll discuss a bit with the team and come back to you.

from vscode-codeql.

charisk avatar charisk commented on July 17, 2024

Thanks for the info! It does seem to be related to CPU/bandwidth. Are you running a particularly complex query?

I've tried to reproduce this (using a basic Azure VM) and generally the extension was generally working okay, however at some point I ran a problem query against the linux kernel database and I saw the same error as you. The CPU was at 90+% and the memory reached 100% at some point.

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024

The query fails.more often when the source equals any(dataflow node).

from vscode-codeql.

charisk avatar charisk commented on July 17, 2024

@Sim4n6 have you tried running any of these queries locally at all rather than through a remote host?

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024

Well, the point of using a remote instance is to circumvent my little laptop perf. The query syntax is correct for sure.

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024

I would share the query... In an hour please.

from vscode-codeql.

charisk avatar charisk commented on July 17, 2024

Well, the point of using a remote instance is to circumvent my little laptop perf. The query syntax is correct for sure.

Make sense!

To give you a bit more context, I'm wondering if something specific to the query/database is hitting a CodeQL performance issue/edge case - that will help us clarify whether this is a CodeQL issue or a VS Code extension issue.

I would share the query... In an hour please.

Thank you. If you don't want the query to be public, feel free to DM me in the Security Lab Slack instance.

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024

But on a laptop with 16G RAM, the query works ... I should definitely avoid that use.

from vscode-codeql.

Sim4n6 avatar Sim4n6 commented on July 17, 2024

Thank you very much.

from vscode-codeql.

charisk avatar charisk commented on July 17, 2024

Are you happy for us to close the issue @Sim4n6 ?

from vscode-codeql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.