Git Product home page Git Product logo

Comments (4)

mlinksva avatar mlinksva commented on June 5, 2024 1

My understanding of RubyGems is obviously tenuous and I don't read closely...noting gem specification aws-sdk-core does find what ought to be in the gemspec file, I see that gemspec files for every installed gem are in (for my local case) ~/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/specifications. I guess that's what you were getting at @jonabc. I'm not sure either. I guess that it could make sense to look there as a fallback in licensed rather than licensee.

from licensed.

jonabc avatar jonabc commented on June 5, 2024

/cc @benbalter @mlinksva do you have an opinion here?

IIRC licensee handles pulling data from project files like *.gemspec as a backup if other explicit license file contents aren't found, however I'm not sure how to tell licensee to look at both the gem's expanded location on disk as well as the gemspec file when they are in two different locations. 💭 ?

from licensed.

mlinksva avatar mlinksva commented on June 5, 2024

It seems the aws-* gems get installed (e.g., in ~/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems) with neither a LICENSE file nor a .gemspec file. I haven't looked into why this is the case, but the result is that licesne[ed] have nothing to work with locally. Compare with jmespath, which is also installed given the example files above, and licensed records the license found in its LICENSE.txt.

from licensed.

jonabc avatar jonabc commented on June 5, 2024

Ok, so to build on that. If this is being handled by licensed, I think the best method to do so would be a Bundler::Dependency subclass that overrides Project#package_manager_file and returns data for the gemspec file if the base implementation doesn't find a file and the spec file exists in the gem specifications directory.

from licensed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.