The project must be hooked up to a build pipeline to build execute tests for incoming PRs and merge commits.

We use Appveyor for Git Extensions, it is preferred but it is not mandated. SignPath that we use for the codesigning integrated best with AppVeyor.

I have a single instance of the app running, and with this the warning text is a bit off:

Perhaps we should check how many instance of the app is actually running (by interrogating running processes?), and adjust the wording appropriately.

Also instead of "these applications" we should say "the application".

Current behaviour:

Searching / installing a new plugin:

Installed plugin:

Expected behaviour:

A user must be able to see the same properties of the installed plugin, e.g. see the link to the repo and be able to click on it.

STR

• disable network connections
• start the Plugin Manager

Most of he original functionality provided by script tools/Prepare-Release.ps1 has been removed in PR #18.
This script is used only for CI builds and called from here:

The remaining functionality of Prepare-Release.ps1 could be entirely moved into appveyor.yml. Afterwards we can fully remove the PowerShell script.

The PluginManager can be opened multiple times by clicking Plugins > Plugin Manager repeatedly. It should be limited to a since instance.

Click on any links in the right panel:

https://github.com/dotnet/sourcelink

Context: I have a crash using it inside the plugin dll and I don't know where is the problem. Using sourcelink would have been made easy to debug the code...

Most important is it on the updates tab.

Either I've completely missed this or this feature currently isn't available.
I wanted to add a custom nuget repository (something we use internally in the company) but I couldn't find a way to add authentication, which is required by this repository.
Please add this, it will be very useful.

Packages have dependency on GitExtensions.Plugins version >=3.1 && < 3.2.
We should display this in UI.

Currently we are not checking required version on the dependency, as discussed in maraf/GitExtensions.PluginManager#36.
If we change our mind, may be this issue will not be needed.

Currently the PM extracts all packages (including itself) directly into the directory UserPlugins. The resulting structure is:

UserPlugins
    Package1.dll
    Package1.config
    Package2.dll
    Package2.config
    ...

This may easily lead to errors due to file name clashes.

The directory structure should be:

UserPlugins
    Package1
        Package1.dll
        Package1.config
    Package2
        Package2.dll
        Package2.config
    ...

Based on changes from gitextensions/gitextensions#7164, we need to call base ctor with boolean parameter (true) from the Plugin.cs.

Different names are used for the PM in different places. Occurrences are "Plugin Manager", "PluginManager" and "Packages".

This is necessary, since we plan to publish our own packages (including PM updates) on GitHub.

Fresh new installment of Git Extensions with version 3.5.4.12724, but plugin manager doesn´t show up.

Not sure if I'm missing something, but I have PackageManager.UI inside C:\Users\user\AppData\Local\GitExtensions\UserPlugins\GitExtensions.PluginManager\PackageManager and the dll at C:\Users\user\AppData\Local\GitExtensions\UserPlugins\GitExtensions.PluginManager

I've seen other tickets with similar issues, but their solutions didn´t work for me.

There's a setting to close GE as soon as PM is started:

IMHO, it is valid to have an option to avoid this popup when a user installs a plugin:

However, the current implementation seems a bit "exaggerated". It always shuts down GE straight away when PM is started, even if the user doesn't install any plugin. Maybe I just clicked the plugin by accident....

I propose to change this into something like "Automatically close Git Extensions when installing plugins (don't ask for confirmation)". The default value should remain false.

Package extraction include write to packages.config should succeed as an unit or any partial outputs should be deleted in case of exception.

Toughts:
Use kind of a transaction log.

Installation

• Save package id and version.
• After each file extraction, save a path to log.
• Write entry to packages.config and delete transaction log.

Unstallation

• Save package id and temp directory patb.
• Copy each file to temp directory.
• Remove entry from packages.config.
• Delete temp directory.

Check transaction log on PackageManager start.

Replace original GE download scripts with dependency on GitExtensions.Extensibility.

The currently used icon is too small (16*16 px) for being properly visualized in the taskbar and in thumbnail previews.
See in comparison to GE:

Ideally, the icon should be available in 256*256 px, to support high-resolution displays.

GE.PM runs as expected when placed in <GE_rootDir>\UserPlugins\*, which is the default location for plugins in GE portable.

However, GE.PM does not run when placed in <user_name>\AppData\Local\GitExtensions\UserPlugins\*, which is the default location for plugins in GE installed version.
I checked with the debugger that GE finds the file <user_name>\AppData\Local\GitExtensions\UserPlugins\GitExtensions.PluginManager.dll, but for some reason the plugin is not loaded correctly.

@maraf: Can you confirm this observation, or do I miss something?

Git Extensions is being migrated to .NET, and many existing packages are targeting the old version of the app that runs on .NET Framework 4.6.1.
The new version of the Plugin Manager shows all known version, which is quite misleading:

Consider how we can filter out (or render) unsupported packages.

Few ideas but nothing concrete, e.g.:

• filter based on the supported application's TFM (i.e. .NET 5.0)
• filter based on the supported version of https://github.com/gitextensions/gitextensions.extensibility

Currently the PluginManager shows an empty browse tab after startup and (apparently) requires to enter some kind of search term:

This is not entirely true. Already in the current version, you can just click on Search (without any search term) and get the full list of available plugins:

It would be much more user friendly to automatically run this search on startup.

• volkanceylan/GitExtensions-SerenityFlow-Plugin (volkanceylan/GitExtensions-SerenityFlow-Plugin#2)
• amcarthur/Zipper (amcarthur/Zipper#1)
• EbenZhang/PReviewer (archived)
• otmopo3/GitExtensionsOpenSolutionPlugin (otmopo3/GitExtensionsOpenSolutionPlugin#2)
• andypaxo/ontime-git-extensions (andypaxo/ontime-git-extensions#4)
• git-tfs/git-tfs-gitextensions-plugin (git-tfs/git-tfs-gitextensions-plugin#20)
• otmopo3/GitLabGitExtensionsPlugins (otmopo3/GitLabGitExtensionsPlugins#4)

The PM builds are not yet signed (#14 (comment)).
We need to change this before including PM into GE's installer.

Git Extensions@master has been migrated to .NET 5.0. Once .NET 6.0 is released the app will be migrated to it.
The plugin manager is currently can't be used with the dev version of the app as it is targeting .NET Framework.

Extend GitExtensions integration (maraf/GitExtensions.PluginManager#19) with option (bool) to check for package updates on startup.
There should also be some limits not to check on every run.

Seems like the publishing date from the package metadata is always missing?

Related to #70, not sure if it was fixed by that one.
If nuget.org is not accessible I can't see the list of installed packages. I have to go the the disk folder to check what is installed and what not.

As suggested in #4 and #5, make PM a modal window.

I tried to install the plugin GitExtensions.SVN via the PM. The plugin is available here: https://www.nuget.org/packages/GitExtensions.SVN/0.2.0.21

It has a dependency on GitExtensions.Extensibility, which is available on the same feed: https://www.nuget.org/packages/GitExtensions.Extensibility/0.1.0.31

Reproduction steps:

1. download and extract the portable build from gitextensions/gitextensions#6664: https://ci.appveyor.com/api/buildjobs/d4jebf45vply353j/artifacts/Setup%2FGitExtensions-Portable-3.2.0.6454.zip
2. open GE and start the PluginManager plugin
3. search for GitExtensions.SVN
4. Nothing is found
   
5. However, the log states that the package GitExtensions.SVN.0.2.0.21 was correctly found, but skipped for some unknown reason:

22/08/2019 22:08:24 root.Search(DEBUG)

Searching 'GitExtensions.SVN'.

22/08/2019 22:08:24 root.Search(DEBUG)

Loading page '0'.

22/08/2019 22:08:24 root.Search(DEBUG)

Searching in 'https://api.nuget.org/v3/index.json'.

22/08/2019 22:08:25 root.Search(DEBUG)

Found 'GitExtensions.SVN.0.2.0.21'.

22/08/2019 22:08:25 root.Search(DEBUG)

Package skipped.

22/08/2019 22:08:25 root.Search(DEBUG)

Loading page '1'.

22/08/2019 22:08:25 root.Search(DEBUG)

Search completed. Found '0' items.

What I found so far

I think I found a problem in

It seems like the package is correctly found on nuget.org, but for some reason the var filterResult is always NuGetPackageFilterResult.NotCompatible (line 131).

If I force the var filterResult to NuGetPackageFilterResult.Ok (line 132, added by me for testing), the PM lists my plugin as expected.
With this trick, I can install, use and uninstall it (I didn't test updating yet):

However, looking in the "Installed" tab, it still says in red the plugin is Not compatible:

Steps to reproduce

1. open PM
2. close GE

What happens?

PM window remains open.

What should happen?

PM window gets automatically closed.

@maraf : is this needed for updates or should this be considered as an undesired behavior?

Environment

• GitExtensions version: 4.0.0.15569
• GIT version: 2.38.1.windows.1
• OS version: Wi10 21H2
• .NET version: 2.2.207, 5.0.408, 6.0.400-preview.22330.6, 6.0.401

Issue description

Per release notes, GitExt 4 requires .Net 6.
When starting PackageManager it crashes with no user feedback,, windows event logs show the entry

Application: PackageManager.UI.exe
Path: C:\lucru\tools\GitExtensions\UserPlugins\GitExtensions.PluginManager\PackageManager\PackageManager.UI.exe
Message: You must install or update .NET to run this application.

App: C:\lucru\tools\GitExtensions\UserPlugins\GitExtensions.PluginManager\PackageManager\PackageManager.UI.exe
Architecture: x86
Framework: 'Microsoft.WindowsDesktop.App', version '5.0.0' (x86)
.NET location: C:\Program Files (x86)\dotnet\

The following frameworks were found:
  3.1.29 at [C:\Program Files (x86)\dotnet\shared\Microsoft.WindowsDesktop.App]
  6.0.6 at [C:\Program Files (x86)\dotnet\shared\Microsoft.WindowsDesktop.App]
  6.0.9 at [C:\Program Files (x86)\dotnet\shared\Microsoft.WindowsDesktop.App]
  6.0.10 at [C:\Program Files (x86)\dotnet\shared\Microsoft.WindowsDesktop.App]```

### Steps to reproduce

1. Start Git Ext
2. (try to) open Plugins -> Plugin manager


### Did this work in previous version of GitExtensions?

yes, yes, yes

### Diagnostics

_No response_

Currently, when a package is found in a feed, versions of the same package from other feeds are ignored.

It is a bit complicated. When a first feed returns enough packages, other feeds are not even searched. PM doesn't know if there are same packages with higher versions or not.

Be careful with this one, this road is fraught with dangers.
In GE we have a number of issues in multi-monitor setups with dialog
windows shown outside visible area or on wrong monitor.

I thing that checking whether a loaded position and size are within boundaries of current displays could solve it.