Commits from TFS cannot be pushed/pulled safely about git-tfs HOT 6 CLOSED

I've just checked when dev-1 and dev-2 has same emails - and it worked as expected (dev-2's push is successfull answered 'Everything up-to-date'). So the issue is actually that commits originated from TFS gets author's email as of current user doing pulling/fetching.

from git-tfs.

It seems I was in a hurry when suggest this. Making stub email won't help much. I wrote a blog post about the reasons:
http://sparethought.wordpress.com/2011/06/16/first-git-tfs-usage-problems/

Probably it is worth mentioning in the wiki so others could read this beforehand. In any case I'm leaving this issue open just to share info. You're free to close it as soon as you think it is reasonable.

from git-tfs.

Huh. I hadn't noticed that before. I had tried to get the commits to be exactly identical, no matter when or where they're created (assuming the same remote config). So, basically, GroupSecurityService.ReadIdentity (used by GetIdentity) is always returning the current user's email (or null)? bah. That really bites.

I think a fix for this would be to make sure that the author email is set to something non-null in TfsChangeset.MakeNewLogEntry.

from git-tfs.

Well, the only viable way I see now is to provide some sort of mapping between TFS' accounts and git's. And when pull/checkin is performed - commits to TFS should go with TFS' account and back with git's.

Just setting something constant non-null is not enough (basically it is 'Second attempt' section of my post).

from git-tfs.

I don't care that it makes the email match what the person is using in git. I mean, it would be nice, but I'd be happiest with usera and userb being able to fetch identical git commits from a given TFS changeset.

After looking through some more git-tfs repos that I have, it looks like there are some that have the right email address for everyone, and some that don't. So I'm not entirely sure what's going on.

I assume your TFS is hooked up to AD. Do users have email addresses stored in their AD records? I think that's where TFS tries to get email addresses.

from git-tfs.

I'd be happiest with usera and userb being able to fetch identical git commits from a given TFS changeset.

Exactly. I just don't know a way to tell git not perform hashing of emails. Otherwise I'd have already done this :)
So trying to make them at least match.

We have VPN tunnel to TFS server. From user account spelling it seems it belongs to some domain (i.e. it has format aaa\bbb), but my working box tied to absolutely different domain than TFS accounts are.

P.S. Offtopic slightly. I don't know if you see/remember of closed issue51 branch :) I tested it half of a day today and it seems ok (just not forget to apply patch provided in the comments or otherwise implement void UpdateRef(string commitHash, long changesetId))

from git-tfs.