NullReferenceException in Sep.Git.Tfs.Core.TfsChangeset.GetPathBeforeRename(Item item) about git-tfs HOT 5 CLOSED

I made a fix in my branch of git-tfs. A pull request was made.

from git-tfs.

Ok that fix was bad. It turns out there are two issues that cause this to be hit on processing Rename changes. One is where the rename doesn't actually have a delete associated with it (item.DeletionId == 0). As far as I can tell when item.DeletionId == 0, we should not try to clean up the original object (http://blogs.msdn.com/roberthorvick/archive/2006/02/09/528651.aspx).

There is another file that is the result of a rename change where DeleteId != 0 though the previous version of the file cannot be found. I've been looking at the history in various ways and can't figure out where the original is for that file. I couldn't resolve this case. :(

from git-tfs.

I've ran into this exact problem, and found item.VersionControlServer.GetItem(item.ItemId, item.ChangesetId - 1).ServerItem would throw an exception e.g.

item.VersionControlServer.GetItem(3891301,72192)
{Sep.Git.Tfs.VsCommon.WrapperForItem}
[Sep.Git.Tfs.VsCommon.WrapperForItem]: {Sep.Git.Tfs.VsCommon.WrapperForItem}
ChangesetId: 'item.VersionControlServer.GetItem(3891301,72192).ChangesetId' threw an exception of type 'System.NullReferenceException'
DeletionId: 'item.VersionControlServer.GetItem(3891301,72192).DeletionId' threw an exception of type 'System.NullReferenceException'
ItemId: 'item.VersionControlServer.GetItem(3891301,72192).ItemId' threw an exception of type 'System.NullReferenceException'
ItemType: 'item.VersionControlServer.GetItem(3891301,72192).ItemType' threw an exception of type 'System.NullReferenceException'
ServerItem: 'item.VersionControlServer.GetItem(3891301,72192).ServerItem' threw an exception of type 'System.NullReferenceException'
VersionControlServer: 'item.VersionControlServer.GetItem(3891301,72192).VersionControlServer' threw an exception of type 'System.NullReferenceException'

Changed to item.VersionControlServer.GetItem(item.ItemId, item.ChangesetId ).ServerItem got it going again, but I am not sure what implications this is going to have.

from git-tfs.

Is this happening when hitting a TFS 2010 server and the changeset where the failure occurs contains a rename? If so, I have proposed a fix to this bug in issue #9.

from git-tfs.

This appears to be resolved by the fix in #9.

from git-tfs.