girosolution / girocheckout_sdk Goto Github PK

Are there any plans on PHP 8 Support?

Hi!

Sendig the Bic as parameter is deprecated, so it shouldn't be mandatory in GiroCheckout_SDK_GiropayIDCheck.php

Not a great fan myself, because the Giropay-Page bank selection page says "Weiter zum Bezahlen" when I am using an authenticate-only project.

There is no class for checking the hash value of a giropay id notification URL, there should be something like:

            $notify = new GiroCheckout_SDK_Notify( new GiroCheckout_SDK_GiropayTransaction_Confirm());
            $notify->setSecret("******");
            $notify->parseNotification( $_GET );

class GiroCheckout_SDK_GiropayTransaction_Confirm extends GiroCheckout_SDK_GiropayIDCheck
{
    /*
     * Includes any notify parameter of the API.
     */
    protected $notifyFields = array(
        'gcReference'=> TRUE,
        'gcMerchantTxId' => TRUE,
        'gcBackendTxId' => TRUE,
        'gcResultAVS' => TRUE,
        'gcAccountHolder' => TRUE,
        'gsAccountIban' => TRUE,
        'gsAccountBic' => TRUE,
        'gcHash' => TRUE,
    );
}

Hello Team,

I am getting this response despite creating the hash using merchantId, projectId, and projectpassword.

Response:

{
"reference": null,
"redirect": null,
"rc": 5002,
"msg": "hash ungültig"
}

When I followed the documentation in a proper way: It is possible to pass in a notifyUrl to a pay page transaction. This url will be called via GET and parameters prefixed with gc will be passed. Accordingly to the parameters there is a hash (gcHash) to validate the request. Is there any helper function inside the SDK to validate such a request easily? I had a look at the examples for the payment page, but I haven't discovered such a function.

When testing the Pseudo card numbers(PKN) with the test data card numbers (https://api.girocheckout.de/en:girocheckout:creditcard:start#test_data) the return message ist always 5102 - "Pseudo-Kartennummer nicht vorhanden".

Is it even possible to test this functionality witt the card numbers listed in the link above? Are there any other test data card numbers that can be used in test environment?

Thanks!

hello! So there's a composer package, nice! - it will take care of optimized autoloading - only loading classes with the girosolution\GiroCheckout_SDK\ prefix. Though as of writing the standalone GiroCheckout PHP SDK on api.girocheckout.de and within the Plugin zipfiles do not include the composer integration and have a lib/GiroCheckout_SDK/GiroCheckout_SDK.php not present in this repo instead.

Unfortunately the implementation will check for presence of project wide classes in its path because of its preload=true parameter to spl_autoload_register. In some PHP configurations (open_basedir set, disabled realpath_cache) this will have a grave performance impact.

I think it would be nice to have the distributables zipfiles with composer too or change the autoloading to something along the lines of the PSR-4 example:
GiroCheckout_SDK.php

        public static function load($classname) {
+               if (strpos($classname, 'GiroCheckout_SDK') === FALSE) {
+                       // move to next autoloader if prefix does not belong to plugin
+                       return;
+               }

I guess you planned for this anyway in the future, but I want to point out it's very much worth the effort.

Hello,
I am using a payment page with timeout in my test account. The timer is shown on the payment page, but when it times out, I don't get a notification via the notifyUrl. I would prefere a notification like "the payment failed".

Is this due to the test account or are such notifications not possible.

When I create a payment page request the response contains an URL like https://pay.girocheckout.de/<ID> which will be redirected to https://pay.girocheckout.de/v1/paypage/de/<ID>

When the page without v1/paypage/de will be opened again, the timer starts from scratch.

Is it possible to get a URL with the v1/paypage/de directly, so that reloading will not reset the timer?