giridharrnair / profstatsutd Goto Github PK

Hardcoded Values in Repo

• Starting from raw data, it would be nice to find a way to not have to commit the data itself but instead create some sort of process to retrieve the data - I'm not sure how you found this data so it might not be possible, but I'm sure you understand why it's suboptimal to have a ton of data just hardcoded in your repo
• A lot of places in the repo could use a combover looking to pull constants out
  • Urls that you make requests to
  • The default classes that you recommend in your "GetSuggestedCourses" DB function

DB Schema

• I don't personally love how difficult it gets to work with your "courses" based around the schema of "APlus", "A", etc.
• It's nice in that you can just sum the grades by summing columns but again it feels super hardcoded to the way that your school does grades / reports their distribution
• In a prod environment you really wouldn't want to convey your "attribute" via N columns
• It would probably be better to turn this into 2 tables that are a 1->many relationship of instructor -> grade count

Describe the bug
Putting "?" or "*" in the Professor input will have no dropdown, yet the professor, Ernan Haruvy, is returned.

To Reproduce
Place a single question mark(or asterisk) in the professor input and nothing in the course input. Click 'Submit.'

Expected behavior
The expected output of putting a single question mark(or asterisk) should be the "Professor not found" toast along with the error page.

Screenshots
"Professor not found" in the dropdown.

"Ernan Haruvy" is given as the professor, instead of there being no professor(or a professor with a ?/* in their name).

Desktop:

• OS: Windows 11
• Browser: Chrome version 120.0.6099.129/130
• Version: ProfStats 1.0.4