Git Product home page Git Product logo

Comments (3)

giannif avatar giannif commented on June 11, 2024

@MickL this is definitely something we would have included if possible. Our Grid require a masonry layout, and there was no way to do masonry with pure css (you can get close, but not quite there).

As far as the regular Gif component, I think at some point in the future we can switch to using srcset to do rendition selection instead of requiring a fixed width, but I'm not sure if we'd be compromising any of our rendition selection algorithm

I'll leave this ticket open and we can try to investigate that at some point

from giphy-js.

MickL avatar MickL commented on June 11, 2024

I understand. Maybe giphy should do the rerendering, tho, not the consumer?

The downside would be that this may add a few more bytes of code to giphy since it may need throttle-debounce or similiar. In my project I entirely use RxJS for things like this so I am fine that I trigger rerendering.

from giphy-js.

giannif avatar giannif commented on June 11, 2024

@MickL I'd like to make it easier to use but I think the width needs to be defined by the user here when they render, and therefore giphy can't do the rerender. Next time I'm working on this part of the code base I'll take a deeper dive but for now it seems okay. Thanks for the feedback

from giphy-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.