giladk / u7-grid-data-type Goto Github PK

It could be fine if the RTE could be embedded direct in the cell. Maybe there could be an option if you want it inline or in modal.

https://our.umbraco.org/projects/backoffice-extensions/u7-grid-data-type/questions-bugs-issues-feedback/70317-datepicker-not-populating-correctly-umbraco-728

Datepicker not populating correctly Umbraco 7.2.8

I ran into this in a project upgraded from 7.1.x to 7.2.8. The problem is due to some Umbraco changes to their stock DatePicker that break the way DTG was using them. I believe this commit is the one that introduced the issue (umbraco/Umbraco-CMS@43f99e1), but several others are at play too.

In this commit, they essentially introduced a "render model" and use that to store the "live" picked value, then when the page is saved (via formSubmitting event), they assign that value to $scope.model.value, which is what DTG is reading. The problem is that DTG also relies on the formSubmitting event, but DTG's is firing first, before the DatePicker has had a chance to assign to $scope.model.value, thus it sees an empty value. Even though you see the picked value in the textbox at first, DTG never actually knows about it since it's not on $scope.model.value yet. This worked before because the datepicker was bound directly to $scope.model.value.

Unfortunately there is no way to control the order of formSubmitting events, and in general it's not a reliable way to handle nested properties.

That being said, here is one hacky workaround that does fix the issue But, I don't know what other problems it might introduce without spending some more time on this, so you'll definitely want to test. This is more to prove the issue and not meant to be a production fix.

The hack: /umbraco/Js/umbraco.controllers.js After line 4849, add: $scope.model.value = $scope.datetimePickerValue;

Some ideas for a proper fix:

Update DTG to force formSubmitting events, similar to Archetype
Update DTG to read the DatePicker value differently, maybe by accessing the render model instead or querying the textbox directly

https://Fyin.com
https://www.linkedin.com/in/DavidDimmer

Hi, I have trouble with datetimes not being valid after adding a new row or sorting the rows. The dates needs to be reset to be valid. This happens in Firefox and Safari.

The umbraco version is 7.2.8.
The date are set to have the date and time setting
Previous I used the hack mensioned in this issue: #1

The hack: /umbraco/Js/umbraco.controllers.js After line 4849, add: $scope.model.value = $scope.datetimePickerValue;

Can it be somehow a problem from the hack or is it from the plugin? Is there something I can do to fix this problem? I belive it has to do with the format, but can be wrong.

Thankful for any help here
/Linnea

I developed a new feature. I suggest that you include it in the plugin :

I just add a few lines of code into two files :
Web/App_Plugins/u7dtg/propertiesPrevalues/contentpicker.html
Web/App_Plugins/u7dtg/u7dtg.controller.js

Code :
changed-files.zip

Steps to reproduce:

1. Create U7DTG data type with a few columns, one being set to a rich text editor.
2. Create document type with field that uses the data type you just created.
3. Create content using the document type you just created
4. Click Open Editor Button to open the modal Rich Text Editor
5. Click the add media icon on the RTE toolbar
6. Modal overlay with class 'umb-overlay-backdrop' has a z-index of 2000 and lays over the top of the RTE modal and the media picker side drawer (despite the drawer having a much higher z-index) because the media picker side drawer is inside of the modal RTE element and it only has a z-index of 1050.

I have implemented a non-ideal fix for this by adding the following line of css to u7dtg.style.css:
[u7dt-rte].modal {z-index: 2001;}
this puts the RTE modal and subsequent media picker drawer above the modal overlay, but ideally the modal overlay would lie over the RTE modal but beneath the media drawer when it is open. However to accomplish this, the modal overlay would need to also be inside of the RTE modal element.

How is this code compatible to umbraco 9? Nice to have an upgrade of this useful add-on data type. Thanks