gigya / gigya-magento Goto Github PK

Description:
Note: Before start reproduce, make sure compilation mode is disabled.

Steps to Reproduce:

1. Go to magento front at http://magento-e.gigyahosting.us/ -
2. Login with social user - you can see GM plugin in front page.
3. Login to admin page in different browser: http://magento-e.gigyahosting.us/index.php/admin (admin/Gigya123)
4. Go to system ->tools -> compilation http://magento-e.gigyahosting.us/index.php/admin/compiler_process/index/key/0e242b9404af5b23e13639fa50f0d8b09b14ea017c0947fffd2c686979cdd16b/
5. Click run compilation process.
6. Go back to magento front at http://magento-e.gigyahosting.us/
   Expected Results:
   GM plugin should work the same

Actual Results:
GM plugin not show up in page

Description:
Default Magento Rating and Review appears instead Gigya Rating and Review.
Note: Before start reproduce, make sure compilation mode is disabled.

Steps to Reproduce:

1. Go to Magento front at http://magento-e.gigyahosting.us/ -
2. Login with social user
3. Go to a product page: http://magento-e.gigyahosting.us/review/product/list/id/406/category/14/
4. You can see Gigya Rating and Review in page.
5. Login to admin page in different browser: http://magento-e.gigyahosting.us/index.php/admin (admin/Gigya123)
6. Go to system ->tools -> compilation
7. Click run compilation process.
8. Go back to magento product page: http://magento-e.gigyahosting.us/review/product/list/id/406/category/14/

Expected Results:
Gigya Rating and Review should appear in page

Actual Results:
Magento Rating and Review appears in page

Having only a userkey instead of the api-secretkey will not allow to save config values in magento backend.

app/code/community/Gigya/Social/sdk/gigyaCMS.php
row 340:
public function testApiconfig() {
$request = new GSRequest($this->api_key, $this->api_secret, 'shortenURL');

will only use $this-api_secret and doesn´t care about user-secret.

As a result the call of the following line in Gigya_Social_Model_Config_Backend_ApiKey will throw an exception:
if ($apiError = $helper->utils->testApiconfig()) {

and no values will be saved. As a short test I disabled the call to testApiconfig() and then values will be saved.

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-1
Explanation: Does README mention REUSE? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Goal
The Client Services team needs to be able to tell the exact version number of the CMS module when reviewing a client's website.

Implementation:
Show the version number in the Magonto configuration > "Gigya Settings" screen.

Version: x.x.x

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-4
Explanation: Is it compliant with REUSE rules? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

While performing the QA review for this site, I noticed that for Site Registration, our request log listed 2 "notifyLogin" calls. The first one fails because nothing is passed in the siteUID field. The second one is successful, however, the "newUser" parameter is now set to "false".

The client is using the Magento module and is not adding any custom code (that is, they are not calling notifyLogin).

when adding a product to cart share action didn't popup

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-2
Explanation: Does it have LICENSES directory with licenses? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-3
Explanation: Is it registered in REUSE? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Description
After update to Magento 3.1 (from file Gigya-Magento-3.1.zip) getting fatal error

• cache cleared

Steps to reproduce

1. Go to magento admin site and login (http://magento-e.gigyahosting.us/admin, user:admin, password: Gigya123)
2. Go to System, configuration, Gigya Global

Expected results
Global settings page loaded

Actual results

Description:
comments & GM stop working when enable compilation mode.
Site: http://magento.gigyahosting.us/

Steps to Reproduce:

1. Admin ->tools -> compilation
2. Click Enable

Expected Results:
comments & GM should work same as before

Actual Results:
comments & GM not show up

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-license_file-2
Explanation: Does it use an allowed license? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Description:

Steps to Reproduce:
Go to http://magento-e.gigyahosting.us/review/product/list/id/410/category/14/

Expected Results:
comments plugin should be ver 2

Actual Results:
comments plugin is ver 1

there is a error getting og:image attribute