giftxtrade / api Goto Github PK

The limit query on /products can accept any numeric value for the limit query. This can lead to crashes as it can be called with a very large value and this significantly slow or even crash the server. See:

The current way to generate draws is through making a POST request to /draws withe the event id as the body, and then calling /draws/confirm/:eventId. The problem with this approach, as noted in issue #3 is that the current algorithm is too slow and does not generate all possible combinations.

Instead, I propose that these draws be generated on the client side and sent to /draws/confirm/:eventId with a POST request with the body holding all draws. This will make for faster draw generation and also allow organizers to manually create pairings.

Emailing participants that have been added manually will help them find out that they've been added to an event. This feature will also be helpful when we implement the "clone event" feature in the future.

The current algorithm is very inefficient, and may cause the event loop to be blocked unnecessarily. In addition, the algorithm also doesn't generate all possible valid combinations.

As the title suggests, the repo is lacking of any testing. It's crucial to make sure that the API is functioning properly and the best way to check is through running unit tests.

Resources

• Testing in NestJS

Tasks

• Add unit tests
• Implement Github Actions to run unit tests

README.md is missing instructions on setting up the auth-tokens.json file.