ghamza-jd / jarust Goto Github PK

An issue to track the development of the Audio Bridge Plugin. Some features are omitted and could be added later on (for example, play_file).

Janus docs: https://janus.conf.meetecho.com/docs/audiobridge.html

• Sync Requests

  • Create
  • Edit
  • Destroy
  • Exist
  • Allowed
  • Kick (#91)
  • Kick all (#91)
  • List rooms
  • Mute (#89)
  • Unmute (#89)
  • Mute room (#90)
  • Unmute room (#90)
  • List Participants

• Async Requests

  • Join
  • Configure (#88)
  • Change room (#93)
  • Leave (#92)

• Events

  • Joined
  • Left (#92)
  • RoomChanged (#93)
  • Participants Updated (#95)

Capture the task handle and cancel it when necessary.

Current we have an abstract transport, which abstract the network transport and have a very generic functionality like send

Here we want to abstract the janus specific transport, so for example we can decorate the message on the transport rather than on the connection. Also, this will help in decoupling the JaSession and JaHandle from JaConnection. And the transaction generation can be their, so JaConnection can have a single responsibility.

currently jaconnectio, jasesseion, jahandle, and jarouter exposes their inners. We should encapsulate them

In addition to the unit tests and integration tests, add e2e tests that spawns a janus server and test the library

Add a request timeout and close pending transactions when timing out.

Add a retry mechanism that requires several retrials and several x amount of units (x seconds, or x milliseconds).

Replace the bounded channels with unbounded ones.

Later on, if we want to support bounded channels we can make it correct rather than the current implementation

The transaction manager only closes transactions on particular cases.

But other cases like a lost message will keep the transaction pending.

Propositions:

• Mutating the transaction manage becomes async and saves the abort handle inside a pending transaction. Then race a timeout with the success close?
• Pause the world to clean stale transactions.
• ...

• Abstract the usage of the transport (#115)
• Favour struct params over usual params, so the APIs have a named arguments
• Use std::sync::Mutex over tokio::sync::Mutex when possible (when we don't hold the mutex between await points)
• Improve documentation

• Web Assembly support
• Video Plugin
• More core messages (e.g.: server_info, detach, ...)

Video room docs: https://janus.conf.meetecho.com/docs/videoroom

• Setup (#102)
• Sync
  • Create
  • Destory
  • Edit
  • Exists
  • List
  • Allowed
  • Kick
  • Moderate
  • enable_recording
  • listparticipants
• Async
  • join
  • configure
  • joinandconfigure
  • publish
  • unpublish
  • start
  • pause
  • switch
  • leave
• Events (TBD)

Inner connection is being leaked, remove the pub

Arbitrary channel sizes are spread across the codebase. It is better to make them parameterized and leave it to the client to decide. Or at least put some rules in place.

Example:

mpsc::channel(10);
mpsc::channel(100);
mpsc::channel(32);