Git Product home page Git Product logo

Comments (7)

mojavelinux avatar mojavelinux commented on May 29, 2024 4

I'm excited to see this happening. Before this is merged in, I'd like you to consider my invitation to graduate this project to the Antora organization on GitLab and making it an official extension of the Antora project. If you decide to accept that invitation, I'd like to suggest that we only merge this change in to that instance instead of this one, thus making a clean break between the old and the new.

from antora-lunr.

ggrossetie avatar ggrossetie commented on May 29, 2024 1

Fixed in 618c126

Please note that future development will happen on GitLab. This repository will be archived and marked as read-only.

We should probably update the README to explain:

  • why the repository is marked as read-only
  • where users can find the latest version (compatible with Antora 3+)
  • that the extension is now an "official" extension for Antora

@thor if you would like to submit a pull request for that, I would be more than happy to review it 🤗

from antora-lunr.

mojavelinux avatar mojavelinux commented on May 29, 2024

I'm ready to graduate the project at any time, though I'd like to bring it in as an extension only (perhaps with a new name). (We can still keep the history).

from antora-lunr.

ggrossetie avatar ggrossetie commented on May 29, 2024

If you decide to accept that invitation, I'd like to suggest that we only merge this change in to that instance instead of this one, thus making a clean break between the old and the new.

That's a good idea. I was actually thinking about how we will manage the transition.
That should indeed make it clear that antora/lunr-extension is the new extension (based on the pipeline feature).

I'm ready to graduate the project at any time, though I'd like to bring it in as an extension only (perhaps with a new name). (We can still keep the history).

Let me know when the repository/project is ready on GitLab 😀

from antora-lunr.

mojavelinux avatar mojavelinux commented on May 29, 2024

@Mogztter How do you feel about the repository name antora-lunr-extension and the package name @antora/lunr-extension?

Or would you prefer something like antora-lunr-integration?

I definitely think "lunr" instead of "lunrjs" is the right choice since the lunr package is without the "js" part.

from antora-lunr.

ggrossetie avatar ggrossetie commented on May 29, 2024

How do you feel about the repository name antora-lunr-extension and the package name @antora/lunr-extension?

Perfect.

Or would you prefer something like antora-lunr-integration?

No extension is better as it refers to the pipeline extension (and sounds better).

I definitely think "lunr" instead of "lunrjs" is the right choice since the lunr package is without the "js" part.

I agree 👍🏻

from antora-lunr.

mojavelinux avatar mojavelinux commented on May 29, 2024

@Mogztter I have set up the new repository. https://gitlab.com/antora/antora-lunr-extension

I could have attempted to import the repository from GitHub, but since the project is being restructured, I figured that might just complicate things. Try to integrate the extension-based branch into the main branch and see how it goes. If something goes sideways, we can start over.

from antora-lunr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.