Git Product home page Git Product logo

Comments (7)

darkyzhou avatar darkyzhou commented on May 29, 2024 1

Unfortunately, darkyzhou/lunr-languages-zh is a complete fork of lunr-languages so I'm a bit unsure...

I guess it would be nice if each language was distributed as a standalone npm package. Then, we could implement a logic to load additional/optional languages.

@darkyzhou What do you think about this idea?

I think it's a nice idea. :)

Since the authors of both lunr-languages and lunr.zh.js are still inactive on GitHub. One can just copy lunr.zh.js's content from the PR and publish it as an individual npm package.

from antora-lunr.

darkyzhou avatar darkyzhou commented on May 29, 2024 1

holy moly, MihaiValentin is back and that PR is merged.

now lunr-languages v1.5.0 natively supports Chinese!

@Mogztter @yangxuan74

from antora-lunr.

yangxuan74 avatar yangxuan74 commented on May 29, 2024 1

Thank you for bringing this to my attention.That's good news.

from antora-lunr.

ggrossetie avatar ggrossetie commented on May 29, 2024 1

holy moly, MihaiValentin is back and that PR is merged.
now lunr-languages v1.5.0 natively supports Chinese!

Awesome news!

Thank you for bringing this to my attention.That's good news.

👍🏻
Feel free to submit a pull request to upgrade to the latest version https://github.com/MihaiValentin/lunr-languages/releases/tag/1.7.0

from antora-lunr.

ggrossetie avatar ggrossetie commented on May 29, 2024

Hello @yangxuan74

We are using https://github.com/MihaiValentin/lunr-languages to provide support for other languages. Unfortunately, lunr-languages does not support Chinese but you can contribute a new language: https://github.com/MihaiValentin/lunr-languages/blob/master/CONTRIBUTING.md

from antora-lunr.

yangxuan74 avatar yangxuan74 commented on May 29, 2024

I found lunr that supports Chinese https://github.com/darkyzhou/lunr-languages-zh, but how does it add toantora-site-generator-lunr?

from antora-lunr.

ggrossetie avatar ggrossetie commented on May 29, 2024

Unfortunately, darkyzhou/lunr-languages-zh is a complete fork of lunr-languages so I'm a bit unsure...

I guess it would be nice if each language was distributed as a standalone npm package. Then, we could implement a logic to load additional/optional languages.

@darkyzhou What do you think about this idea?

from antora-lunr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.