gfarrell / kords Goto Github PK

When you're on a room page and typing in the comments textarea, if you use the left/right arrow keys to attempt to move the cursor through the textarea, it changes to the next room sequentially, losing your comment.

Windows 7, Chrome 24.0.1312.57 m

SecurityComponent is black-holing requests to Rooms->delete from Rooms->view

The request has been black-holed
Error: The requested address '/rooms/735/delete' was not found on this server.

Stack Trace
#0 /Users/gideon/Code/Kords/source/software/site/lib/Cake/Controller/Component/SecurityComponent.php(207): SecurityComponent->blackHole(Object(RoomsController), 'csrf')
#1 [internal function]: SecurityComponent->startup(Object(RoomsController))
#2 /Users/gideon/Code/Kords/source/software/site/lib/Cake/Utility/ObjectCollection.php(110): call_user_func_array(Array, Array)
#3 /Users/gideon/Code/Kords/source/software/site/lib/Cake/Controller/Controller.php(606): ObjectCollection->trigger('startup', Array)
#4 /Users/gideon/Code/Kords/source/software/site/lib/Cake/Routing/Dispatcher.php(104): Controller->startupProcess()
#5 /Users/gideon/Code/Kords/source/software/site/lib/Cake/Routing/Dispatcher.php(89): Dispatcher->_invoke(Object(RoomsController), Object(CakeRequest), Object(CakeResponse))
#6 /Users/gideon/Code/Kords/source/software/site/app/webroot/index.php(96): Dispatcher->dispatch(Object(CakeRequest), Object(CakeResponse))
#7 {main}

I have a feeling it's because of the post method being enforced so form submission is required. Maybe it's worth scrapping that requirement.

e.g. Mobile, netbooks etc..

Leaving a room page having typed a comment and not pressed submit means you lose the nice comment you typed :-(. It would be nice to have a dialog pop up and ask if you're sure you want to leave the current page without submitting your comment.

And wouldn't require too much tweaking presumably, as you already have all the locations. Just need to sort them into internal and external. Thanks!

I'm not sure how best to get the fixes here (or even if you want to), but I've fixed it all on the KCSU society area in SRCF, to use Cake 2.10 (which fixes a bunch of incompatibilities with PHP7, although it then introduced a bunch of other breakages...).

An auto-refresh checkbox would be good so that RoomFilterController keeps refreshing every 60 seconds or so when checked.

I know it's not particularly useful but I've always been curious to see which rooms have double beds and I'm sure other people are too, so if it's easy enough maybe you could put it in? Also one problem with using github to deal with requests is that people will have to make accounts, and most people won't be bothered... perhaps suggest github OR E-mail?

Sami