Git Product home page Git Product logo

Comments (3)

cleptric avatar cleptric commented on June 16, 2024 1

@stayallive can you take a look please?

from sentry-php.

stayallive avatar stayallive commented on June 16, 2024

It does look like we can improve here, our ErrorHandler is doing more work then needed because it has no access to the SDK options to know what it can skip. We could basically skip all this work:

sentry-php/src/ErrorHandler.php

Lines 329 to 339 in 51cec5c

if ($isSilencedError) {
$errorAsException = new SilencedErrorException(self::ERROR_LEVELS_DESCRIPTION[$level] . ': ' . $message, 0, $level, $file, $line);
} else {
$errorAsException = new \ErrorException(self::ERROR_LEVELS_DESCRIPTION[$level] . ': ' . $message, 0, $level, $file, $line);
}
$backtrace = $this->cleanBacktraceFromErrorHandlerFrames($errorAsException->getTrace(), $errorAsException->getFile(), $errorAsException->getLine());
$this->exceptionReflection->setValue($errorAsException, $backtrace);
$this->invokeListeners($this->errorListeners, $errorAsException);

I'm working on a way to make the ErrorHandler somehow aware of the configured error_types but it is a bit tricky because of the singleton and not wanting to make any backwards incompatible changes.

from sentry-php.

stayallive avatar stayallive commented on June 16, 2024

Please note that you are on version 3.6.0 and if we make any changes this will only be released in the latest release so you'd need to upgrade to 4.x (4.7.0 is the latest of today). Possibly an update to 4.x will already help a bit in your situation and it would be good to know the issue still persists if you upgrade to 4.x!

from sentry-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.