Compile Error: Declaration of Http\Message\Encoding\FilteredStream::seek(int $offset, int $whence = Http\Message\Encoding\SEEK_SET): void must be compatible with PsrExt\Http\Message\StreamInterface::seek($offset, $whence = NULL) about sentry-php HOT 8 CLOSED

PsrExt is a strange namespace, is that maybe related to ext-psr? https://github.com/jbboehr/php-psr
I advise you to remove that extension, is not in sync with the proper PHP-FIG packages.

from sentry-php.

Psrext represents PSR extension installed as php module and yes it is https://github.com/jbboehr/php-psr, it is required because phalcon 4 needs it and the project is in phalcon4,
What i am more concerned about is, how the error started suddenly, because the same code and same modules were running perfectly before 7th march.

Here is phalcon4 link https://github.com/phalcon/cphalcon/tree/v4.1.2?tab=readme-ov-file

from sentry-php.

You probably triggered a new codepath or updated some library. In particular, your error is that you're using an older ext-psr version that does not have types for its arguments (PsrExt\Http\Message\StreamInterface), while the implementation that lives in your vendor does (Http\Message\Encoding\FilteredStream).

You have to either upgrade the ext or downgrade the library.

I'm closing here since it's clear that it's not Sentry's fault, but feel free to continue replying if you need more details.

from sentry-php.

@Jean85 Thanks for the response,
I am well aware of the issue that function definition is incompatible,
But the same code with same package worked perfect till 7th march, and suddenly errors started coming in on 7th march,

Also i am not using the php-http/message package directly, it is dependency of sentry as you can see here
https://github.com/getsentry/sentry-php/blob/3.22.1/composer.json#L32

the error is showing in the file:vendor/php-http/message/src/Encoding/FilteredStream.php at line 178
which is file of the php-http/message package.
https://github.com/php-http/message/blob/1.x/src/Encoding/FilteredStream.php#L175

Now ideally it would extend the the Psr\Http\Message\StreamInterface class from psr module which is old,
but sentry has another package which overrides the dependency of psr module which is in "php-http/client-common"
https://github.com/getsentry/sentry-php/blob/3.22.1/composer.json#L29

now above package requires "psr/http-message" which overrides the name space of PSR module
here is the file: https://github.com/php-fig/http-message/blob/master/src/StreamInterface.php
now all of these packages are installed in my code base,
so ideally this should be extended from sentry code and not the namespace of php extension, and psr/http-message package has compatible function definition.

My main concern is still with how a perfectly running code of sentry, suddenly started throwing error,
might be the code was already there, but some response data changed which triggered that code to execute and we got this error.

thanks for the help.

from sentry-php.

The change could be in the 429 response from the server. That kind of response is a "Too Many Requests", so you're getting rejected, I don't know if you're making too many requests, if you're out of your paid quota or whatever.

The fact that the php-http packages is a sub dep of Sentry still your concern, not ours, since the fact that you're overriding the psr/http-message with an extension changes everything. You're basically getting this issue: jbboehr/php-psr#87

from sentry-php.

Hey @Jean85,
Just want to clear out that i don't want any changes from sentry side, i am just here to understand what went wrong and how i can avoid this kind of issues in future. because as i said it suddenly started coming in with the same code which was running in a container from 15 days.

One more question
Is this 429 response was changed around 7th march from sentry servers?
because for 200 response code sentry was working perfectly before and i guess earlier we were not getting 429 responses from sentry server.

Also JFI i have not explicitly override psr/http-message with psr extension it is how it is from 1.5 years in my code, and it was working perfectly fine.

thanks

from sentry-php.

I'll try to answer your doubts point by point:

• you DO override psr/http-message, or well, the extension does the override for you, but only at the code level
• you can't expect that your code stays ok if you do not upgrade your dependencies; in this case, the PSRs have went through a round of upgrades (for which I'm partially responsible, since I'm the author of the this bylaw) and the depending libraries (like php-http) have consequently adapted to it
• in your specific case, you have PSR-7 psr/http-message as went through 1.1 (which adds types to method arguments) and 2.0, which adds method return types
• your vendor folder seems to include psr/http-message 2.0, BUT the extension is providing the equivalent of 1.0, and this generates the error that you're reporting
• so, you should declare the explicit replacement in the composer.json (as suggested in the extension readme) or at least declare it as an explicit require constraint (i.e. composer require psr/http-message ^1.0), so that Composer can avoid installing psr/http-message 2.0 (which is probably what's happening to you right now)
• as for the 429 response, the Sentry docs explicitly says:

When you exceed your quota threshold, the server will respond with a 429 HTTP status code, which communicates to SDKs and clients to stop sending events. This status code comes with a Retry-After header that indicates the time for which this rate limit is active. However, clients are not supposed to retry events, but instead drop events until the rate limit has expired, to prevent queue backlogs. Note, that since event ingestion and rate limiting happen asynchronously, the 429 HTTP status code is always slightly delayed.

So, you have a quota configured on your account, and you're exceeding it.

from sentry-php.

Okay thanks @Jean85 for clearing out the doubts,
it makes sense that framework might be overriding the namespace,

I agree with you that older dependency would break sometimes,
but still my main doubt is how the same code which was running perfect in the same server environment, started getting the error 😄, there might be some change in sentry server architecture or response headers or something.
I guess i will not find out what exactly made the perfectly running code to break, but i will surely keep my dependencies updated from now on.

Also thanks for pointing the doc on php-psr repo, adding psr/http-message:1.0 fixes the issue,
But i will be upgrading sentry package to latest version.

Thanks for all the help and let me know if you get any information if there were any changes around 7th march.
🤝

from sentry-php.