Error in sentry_sync.c file about sentry-native HOT 6 CLOSED

The error is occuring at the following lines (I commented the piece of code to build successfully):

void
sentry__bgworker_start(sentry_bgworker_t *bgw)
{
    SENTRY_TRACE("starting background worker thread");
    sentry__mutex_lock(&bgw->task_lock);
    bgw->running = true;
    //if (sentry__thread_spawn(&bgw->thread_id, &worker_thread, bgw) != 0) {
    //    bgw->running = false;
    //}
    sentry__mutex_unlock(&bgw->task_lock);
}

from sentry-native.

@rafagan I think PR #168 contains some fixes related to calling conventions which look like they are related.

As you created quite a bunch of reports, can you please write the exact OS/toolchain/compiler versions that you are using? cmake and cmake build output different versions.

from sentry-native.

-- Building for: Visual Studio 16 2019
-- The C compiler identification is MSVC 19.22.27905.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.22.27905/bin/Hostx64/x64/cl.exe
[…]
Microsoft (R)-Build-Engine, Version 16.2.37902+b5aaefc9f für .NET Framework

I think I have the latest versions of everything. Not quite sure what versions are running on Azure, but we use the windows-latest image there as well, so probably quite recent versions as well.

If you have some older/outdated versions, I can take a look at reproducing this locally for me.

from sentry-native.

Try with Microsoft (R) Build Engine version 15.5.180.51428 (MSVC++ 2017) x64 and cmake 3.17.0-rc2.

from sentry-native.

ah yes, I have pulled the fix from #168 into #176 , which at least fixes this build failure on VS2017.
We will extend our testsuite to cover more compiler permutations, and will clean up all this along the way

from sentry-native.

I'll try again today with MSVC++2019 and then return here to post status

from sentry-native.