Comments (2)
Yes, that would be exactly it.
I guess just doing it in our own SDK code so it is being set correctly in the inproc handler on Android is enough.
If someone is using their own unwinder and create their own stack traces, it is their responsibility to set the proper value, which is a oneliner.
from sentry-native.
Is the idea here (for now) to add this only for libunwindstack
as a special case, or should we expose this cleanly in the API too?
For the former, I would do something simple like the following here:
#ifdef SENTRY_WITH_UNWINDER_LIBUNWINDSTACK
// libunwindstack already adjusts the PC according to `GetPcAdjustment()`
// https://github.com/getsentry/libunwindstack-ndk/blob/1929f7b601797fc8b2cac092d563b31d01d46a76/Regs.cpp#L187
// so there is no need to adjust the PC in the backend processing.
sentry_value_set_by_key(stacktrace, "instruction_addr_adjustment",
sentry_value_new_string("none"));
#endif
from sentry-native.
Related Issues (20)
- MSVC static lib build produces PDB that's not recognized by Sentry CLI HOT 8
- sentry_init() takes too much time and blocks UI thread HOT 5
- deadlock in sentry__bgworker_submit and worker_thread HOT 1
- Feature Request: Support OTEL for native C/C++
- Crashpad Handler Unintended Behaviors after installation of Sentry HOT 13
- Crashpad on Android
- inproc: backtrace() on recent macOS no longer produces a stack-trace in the signal-handler HOT 7
- sentry-native -> external/crashpad -> third_party/zlib is out of date HOT 2
- Backend selection for static lib HOT 4
- Static build with breakpad on windows fails to link HOT 5
- Using `sentry_set_user` but no users show up in dashboards HOT 9
- New API to delliberately crash the application
- Feature Request: Support for ESP32 microcontroller HOT 2
- sentry-native is missing tracing functions (e.g. continueTrace) HOT 2
- Support for nuget packages HOT 3
- [c++]Sentry Unable to report Crashes when running as Daemon/systemd service HOT 9
- Unable To Register Crashpad WER DLL In Packaged Application HOT 6
- Debug files retention policy HOT 4
- Trouble sending crash reports in AWS Lambda execution environment HOT 5
- Sentry Native delays app termination if device is not online HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-native.