Hi GeoExt Team !

In GeoExt version "pre-2.0", the property "layer" of a TreeNode configuration could be a layer's name instead of a the Layer object itself.

That was a welcome shorthand when the LayerTree composition comes from a JSON string, like when the attached store has an Ajax data source.

My workaround for now is to add a listener in the LayerTree's configuration:

var options = {
    ...
    listeners: {
        beforeitemappend: function (_this, node) {
            if (node.data.layer && (typeof node.data.layer == 'string') ) {
                var x = my_application.my_map.getLayersByName(layer);
                if (x.length > 0) {
                    node.data.layer = x[0];
                }
            }
        }
    }
}

The regression seems bogus, nevertheless the feature is hotly appreciable.
I can suggest a fix if needed but the snippet in GeoExt version "pre-2.0" was ok.

Code where the layer is fetched from the node configuration:
File: "/src/GeoExt/tree/LayerNode.js", line:

    init: function(target) {

        this.target = target;
        var layer = target.get('layer');

As discussed the tests are adressed by @adube

See also #8 and #66

Dear all,

i would like to print vector data with an individual style. My current code looks like
this:

sourceMap = this.getMappanel().map;

// The PrintProvider that connects us to the print service
printProvider = Ext.create('GeoExt.data.MapfishPrintProvider', {
method: 'POST', // 'POST' recommended for production use
capabilities: printCapabilities, // provide url instead for lazy loading
customParams: {
mapTitle: 'Print something',
comment: 'Paper maps for the masses'
}
});

printMapPanel = Ext.create('GeoExt.panel.PrintMap', {
itemId: 'printPanel',
layout: 'fit',
sourceMap: sourceMap,
printProvider: printProvider
});

printDialog = Ext.create('Ext.Window', {
title: 'Print Preview',
layout: 'fit',
height: 600,
width: 400,
items: [printMapPanel],
bbar: [{
text: 'Create PDF',
handler: function(){ printMapPanel.print(); }}]
});
printDialog.show();

Now to the problem:

The variable sourceMap contains the printable vector layer including a
Stylemap. Normally, each feature is represented on the map as an orange
dot (openlayers default settings). In the Stylemap each feature receives a
PNG graphic. Everything is displayed correctly on the map. In the preview
window, the features are shown, but the Stylemap is gone. Accordingly, the
features are printed, but not the correct symbols. Once the card is added
to the PrintMap, all the style information are lost. How can I fix this?

Best Regards

BarreBraeu

We have many components for legends in GeoExt 1. We need to have the same functionality in GeoExt 2.

http://geoext.github.io/geoext2/examples/printextent/print-extent.html

console errors on page load:

Failed to load resource: net::ERR_ADDRESS_UNREACHABLE
Uncaught ReferenceError: printCapabilities is not defined 

I am working on a project that needs this functionality. Would love to see this in action.

alias : 'reader.feature', should be alias : 'reader.gx_feature',

Due to an issue within the MapPanel (#42) it is necessary to port the zoomslider component first.

We'll use GeoExt.panel.Map.

The resizeFunction is assuming erroneously when setting style of the dom element, that height and width are numeric values. That doesn't work. You must pass to the setStyle a string like "33px".
Following there is patch (tested)
Index: lib/GeoExt2/src/GeoExt/slider/MapPanelItem.js

===================================================================

--- lib/GeoExt2/src/GeoExt/slider/MapPanelItem.js   (revision 421)
+++ lib/GeoExt2/src/GeoExt/slider/MapPanelItem.js   (revision )
@@ -102,9 +102,9 @@
                     el.setStyle({
                         top: dim.top,
                         left: dim.left,
-                        width: dim.width,
+                        width: "" + dim.width + "px",
                         position: "absolute",
-                        height: dim.height,
+                        height: "" + dim.height + "px",
                         zIndex: panel.map.Z_INDEX_BASE.Control
                     });
                     // This is tricky...
@@ -113,14 +113,14 @@
                         // element is controlled by the height of the element
                         // with the 'x-slider-inner'-class
                         el.down('.x-slider-inner').el.setStyle({
-                            height: dim.height - me.thumbWidth
+                            height: "" + (dim.height - me.thumbWidth) + "px"
                         });
                     } else {
                         // ...but for horizontal sliders, it's the form element
                         // with class 'x-form-item-body' that controls the
                         // height.
                         el.down('.x-form-item-body').el.setStyle({
-                            height: me.thumbHeight
+                            height: "" + me.thumbHeight + "px"
                         });
                     }
                 };

I have been working on porting an application from GeoEXT-1.1/ExtJS-3.4.0 to GeoEXT2/ExtJS -4.1.0 and have experienced the following issues in Internet Explorer (testing in both IE8 & IE9).

• IE8 errors on LayerLegend.js (line 45) Object deosn't support property or method 'indexOf'
  • Workaround: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/indexOf
• IE8 errors on Action.js (line 269) Object deosn't support property or method 'bind'
  • Workaround: http://debugfix.com/2012/03/script438-object-support-property-method-bind/
• IE8 errors on LayerLegend.js (line 37) Object deosn't support property or method 'supports'
  • Workaround hack to hard code 'supports' function:

//score = GeoExt.LayerLegend.types[type].supports(layerRecord);
if (layerRecord.getLayer() instanceof OpenLayers.Layer.WMS || layerRecord.getLayer() instanceof OpenLayers.Layer.Vector) {
    score = 1;
} else {
    score = 0;
};

As discussed in #231, the WMS used in most examples is really slow for a longer period of time now.
Any suggestions for changing the WMS to a faster one are welcome.
As an option i could include our new OSM-WMS (http://ows.terrestris.de/dienste.html#openstreetmap-wms), but its support for EPSG:4326 has to be configured to look good without the distortions it has currently from reprojecting from EPSG:900913

The PrintMapPanel tests fail, and the PrintMapPanel code is a bit of a mess.

We need a framework for i18n. And we need to figure out if we reuse what's in GeoExt 1 or not.

Hello All
i am new for the GeoExt, when I try to use GeoExt 2 to create a layers tree with radio button, but when click the radio button, not like 1.1, it will become unselected, is that a bug or I have to make a setting?

Thanks
Joseph

It seems to be a regression between version "pre-2.0" and "2.0.0".
In GeoExt "pre-2.0" items of a LayerTree can have both a layer and children.
In GeoExt "2.0.0" children are deleted when the item have a layer.

This bug seems related to issue #212 in that the code of "LayerNode.js" available in "pre-2.0" seems to be abandoned in "2.0.0".

The patch below worked for my application and solved both issues #212 and this current one. It just consists in applying a snippet of "pre-2.0" on "2.0.0".

diff --git "a/src\\GeoExt\\tree\\LayerNode.js" "b/src\\GeoExt\\tree\\LayerNode.js"
index cad9e0c..354f9a7 100644
--- "a/src\\GeoExt\\tree\\LayerNode.js"
+++ "b/src\\GeoExt\\tree\\LayerNode.js"
@@ -36,25 +36,49 @@ Ext.define('GeoExt.tree.LayerNode', {
     init: function(target) {

         this.target = target;
-        var layer = target.get('layer');
-
-        target.set('checked', layer.getVisibility());
-        if (!target.get('checkedGroup') && layer.isBaseLayer) {
-            target.set('checkedGroup', 'gx_baselayer');
+        this.layer  = target.get('layer') instanceof OpenLayers.Layer && target.get('layer');
+       
+        if ( !this.layer ) {
+            // guess the store if not provided
+            if ( !this.layerStore || this.layerStore == "auto") {
+                this.layerStore = GeoExt.panel.Map.guess().layers;
+            }
+            
+            // now we try to find the layer by its name in the layer store
+            var i = this.layerStore.findBy(function(o) {
+                return o.get("title") == this.target.get('layer');
+            }, this);
+            if ( i != -1 ) {
+                // if we found the layer, we can assign it and everything
+                // will be fine
+                this.layer = this.layerStore.getAt(i).getLayer();
+                
+                target.set('layer', this.layer); 
+            }
         }
-        target.set('fixedText', !!target.text);
-
-        target.set('leaf', true);
+        
+       if ( this.layer ) {
+            target.set('checked', this.layer .getVisibility());
+            if (!target.get('checkedGroup') && this.layer.isBaseLayer) {
+                target.set('checkedGroup', 'gx_baselayer');
+           }
+            target.set('fixedText', !!target.text);
+            
+            if ( !target.childNodes.length )
+                target.set('leaf', true);
+            
+            if(!target.get('iconCls')) {
+                target.set('iconCls', "gx-tree-layer-icon");
+            }
+            
+            target.on('afteredit', this.onAfterEdit, this);
+            this.layer.events.on({
+                "visibilitychanged": this.onLayerVisibilityChanged,
+                scope: this
+            });

-        if(!target.get('iconCls')) {
-            target.set('iconCls', "gx-tree-layer-icon");
-        }
+       }

-        target.on('afteredit', this.onAfterEdit, this);
-        layer.events.on({
-            "visibilitychanged": this.onLayerVisibilityChanged,
-            scope: this
-        });
     },

     /**

When using Ext 4.1.3 with GeoExt2 the Ext.tree.Column file throws an errors with 'Unable to get value of the property 'apply': object is null or undefined' on line 41.

The renderer code in Ext.tree.Column has changed from 4.1.0 to 4.1.1. From my investigation the bug is a scoping bug and I have temporarily fixed the issue by creating an override for GeoExt.tree.Column initComponent method.

Changed Line 28:
var buf = [parentRenderer(value, metaData, record, rowIdx, colIdx, store, view)];
To
var buf = [parentRenderer.call(this, value, metaData, record, rowIdx, colIdx, store, view)];

If I have posted this in the wrong place or if this version is not dealing with 4.1.1 then please ignore.

We need data components modeled around the Ext JS 4 concepts. See https://github.com/geoext/geoext/tree/master/lib/GeoExt/data to know what we have today on GeoExt 1.

We have a bunch of issues in IE with all current tests.

• The Ext.Loader fails to load components when using a ext-debug.js file that is not hosted locally. The 80020101 is fired.
• We tried to load a local version. It worked partially. When specifying files required/used inside a test page, some file(s) fail to load. When 'Ext.layout.container.Border' is added to the requires list, IE fails to load it and it breaks the tests.

So, to follow our main objectives, we should forget about that issue, switch back to loading ext-all-debug, which fixes the issue.

When opening the print examples, e.g.

http://geoext.github.io/geoext2/examples/printpreview/print-preview.html

you will get a 404 in your Browser and the example won't load because of missing sources:

http://demo.opengeo.org/geoserver/pdf/info.json?var=printCapabilities

@ahocevar / @bartvde :
Is there a new URL available for a public print servlet, maybe from boundlessgeo?
I made a quick search but could not find anything.

Besides, the WMS used in most examples (e.g. mappanel), retrieved from
http://vmap0.tiles.osgeo.org/wms/vmap0?
is painfully slow today (30 seconds per tile). Not sure if this is just a temporary issue.

When using the protocol config to load features in a FeatureStore and then load the features form the FeatureStore to a Vector Layer, the features are not added.

Example :

• the layer I want : layer.features[x] = my feature
• the layer I get : layer.features[0].features[x] = my feature

In other words the "features" parameter of the layer contains another "features" attributes, which is wrong IMHO.

In think this is a bug because the features are not displayed at all on the layer.

I found a way to resolve it :
In the file : GeoExt2/src/GeoExt/data/proxy/Protocol.js

I changed the line 108 :

• FROM : "var result = o.reader.read(response);"
• TO : "var result = o.reader.read(response.features);"

As a result of this patch, the features are displayed correctly.

Thank you in advance,

Julien Collard

The GetExt-2 work was based on GeoExt 1.0, so we should try to apply all changes after release 1.0 to GeoExt-2.

Unfortunately, the "release-1.0" tag in the getext/geoext GitHub repository isn't very helpful, as it is part of a completely separate tree from master. However, the corresponding SVN commit was r2438, which can be found in master as the following commit:

geoext/geoext@b1baab0

So only changes after this commit are interesting to us.

A manual inspection of the history of lib/GeoExt/widgets/MapPanel.js (GeoExt-1), compared with its corresponding src/GeoExt/panel/Map.js (GeoExt-2), shows that some more changes are already part of GeoExt-2. I identified all changes up to the following commit in GeoExt-2, at least regarding MapPanel.js:

geoext/geoext@223574e

So only changes after that commit are interesting to us.

When concentrating on MapPanel, and ignoring all commits which just changed some comment, the following changesets should be ported to GeoExt-2:

1. geoext/geoext@3257686
2. geoext/geoext@b263b4a
3. geoext/geoext@6ac9c81
4. geoext/geoext@26a17c5

Note that the 2. changeset undoes some parts of the 1. changeset.

A similar analysis should be performed at least for GeoExt-1's LegendPanel, FeatureRenderer, PermalinkProvider, LayerRecord, and LayerStore.

I have a vertical zoom slider with height: 100 which displays fine the first time. But when the map panel is resized, it gets messed up, see:

To reproduce:

• Open http://geoext.github.io/geoext2/examples/zoomslider/zoomslider.html
• Both sliders correctly start at zoom level 4
• drag the lower slider outside of the map very quickly from left to right and back again
• try to release the slider somewhere in the middle of the allowed range

Most of the time you will now see that the lower slider says the zoom is e.g. 7, while the slider in the map (and the map itself) will report the zoom to be 0 (GeoExt.panel.Map.guess().map.zoom === 0).

There are two issues here:

1. the sliders should never be out of sync
2. the map should display the layer at zoomlevel 0 and not show a pink tile

GeoExt 1 has many layer tree components/plugins. We need to the same level of functionality in GeoExt 2.

I actually work with the "FeatureStore" class and I need to filter my features depending on many attributes but not just just one.

So I decided to override the "onLoad" function to use the native store's filter and it's looks like that :

onLoad: function(store, records, successful, eOpts) {
  this._removing = true;
  store.layer.removeAllFeatures();
  delete this._removing;

  // Array of the records I'll keep for the layer.
  var keepedRecords = [];

  for (var i = 0; i < records.length; i++) {

    var aRecord = records[i];
    var filtersOK = true;

    // I verify if the records match with each filters and, if not, I exclude it from the record's array.
    for (var f = 0; f < store.filters.items.length; f++) {
      var aFilter = store.filters.items[f];
      if (!aFilter.filterFn(aRecord)) {
        filtersOK = false;
        break;
      }
    }
    if (filtersOK) {
      console.log(aRecord);
      keepedRecords.push(aRecord);
    }
  }

  // Finally I add my keeped records to my layer.
  this.addFeaturesToLayer(keepedRecords);
}

For example I have this filter :

{
  property: "myAttribute",
  value: myValue
}

That works perfectly for me. I've just not ever try by modifying my filters yet but I'll do it soon.

Have you another solution tu use many filters in a FeatureStore ?

Thank you in advance,

Julien Collard

The ZoomSlider example now acts weird. It doesn't follow the mouse correctly and sometimes zoom out when trying to zoom in for example. This behavior appered after the Ext 4.1 upgrade.

When adding new Features to a FeatureStore, all previous Features in the VectorLayer are deleted. See also my report in the mailing list (http://www.geoext.org/pipermail/users/2012-May/002977.html).

I tried to fix this issue with the help of the useful comments received in the mailing list, but unfortunately, I did not succeed. You can have a look at my attempt here: lvonlanthen@b14e9cf. While I was able to add multiple Features to the VectorLayer, the very same Feature can still be added twice, which probably should not happen. Therefore, the last test I've written fails.

Since I probably will not be able to work on this for the next couple of days, I thought I'd just let you know what I did. And maybe my work is of use to anyone more familiar with the whole code.

There is something wrong in GeoExt.data.FeatureStore ,

I followed this example to load WFS vector features into a grid.
http://geoext.github.com/geoext2/examples/grid/feature-grid.html

It works once, then fails many times, then suddenly works once again ... and so on.

If an OpenLayers.Layer.WMS() is defined and multiple layers are selected, geoext should take into account layers wms_title layer metadata instead of layer name when it's used in a geoext.tree.layercontainer.

I am using mapserver as WMS server and in this case layer names are used in geoext.tree.layercontainer.
Problem with this behavour is that according to OGC specifications layer's name are not supposed to be "human friendly" (eg. no spaces, lowercase). This results in ugly layer names in geoext.tree.layercontainer

Hope this is clear.
Regards

In the PrintPage example is still used the GeoExt.data.PrintProvider which was renamed to GeoExt.data.MapfishPrintprovider.
Online example in gh-pages branch is runnig because it is not updated yet.

I taked a test.
I set the same Bounds, and the mappanel's zoom is different with the official Openlayers 's map:
eg:
1.the Openlayers's map test.
var map, Layer;
var epsg4326 = new OpenLayers.Projection("EPSG:4326");
var epsg900913 = new OpenLayers.Projection("EPSG:900913");
function init(){
map = new OpenLayers.Map('map');
layer = new OpenLayers.Layer.OSM( "Simple OSM Map");
map.addLayer(layer);
var bounds= new OpenLayers.Bounds(-3.8207960123447,40.404968321436,-3.7753915781471,40.432086647938).transform(epsg4326,epsg900913);
map.zoomToExtent(bounds);
alert(map.getCenter()+":"+map.zoom)
}
the zoom is 13.
2. the mappanel's test, I updated the mappanel.js

name: 'HelloGeoExt2',
launch: function() {
var epsg4326 = new OpenLayers.Projection("EPSG:4326");
var epsg900913 = new OpenLayers.Projection("EPSG:900913");
var map = new OpenLayers.Map({});
map.addLayer(new OpenLayers.Layer.OSM());
mappanel = Ext.create('GeoExt.panel.Map', {
title: 'The GeoExt.panel.Map-class',
map: map,
//center: '12.3046875,51.48193359375',
//zoom: 6,
//stateful: true,
//stateId: 'mappanel',
extent: new OpenLayers.Bounds(-3.8207960123447,40.404968321436,-3.7753915781471,40.432086647938).transform(epsg4326,epsg900913),//'12.87,52.35,13.96,52.66',
dockedItems: [{
xtype: 'toolbar',
dock: 'top',
items: [{
text: 'Current center of the map',
handler: function(){
var m = GeoExt.panel.Map.guess().map;
alert(m.getCenter()+"zoom:"+m.zoom);

                }
            }]
        }]
    });
    Ext.create('Ext.container.Viewport', {
        layout: 'fit',
        items: [
            mappanel
        ]
    });
}

But the zoom is 15.
It has the same 'new OpenLayers.Bounds(-3.8207960123447,40.404968321436,-3.7753915781471,40.432086647938).transform(epsg4326,epsg900913);' and the same centerLonLat.

why it's different ?
Thanks.

We need to figure this out during the code sprint.

this is not the case for at least:

src/GeoExt/selection/FeatureModel.js
src/GeoExt/form/action/Search.js
src/GeoExt/data/reader/Feature.js

In the GeoExt Legend Tree example you can observe some strange behaviour with the gx_wmslegend components. Starting the example which contains three Layers, an

Ext.ComponentQuery.query('gx_wmslegend')

shows me 11 components on initial page load. If you toggle a layer off and on again, the number increases on every toggle. Seems like the update method in WmsLegend.js causes this behaviour. I dont think its right to create new legend components if a layer is toggled and the zoomlevel has not changed in the meantime. A simple hide / show should be enough.

The GeoExt Legend Panel Example seems to work ok, cant see any duplicates there.

Hi! I have a map in a collapsible panel. In Firefox and IE, when the panel collapses, the features and the scale bar are not hidden.
How can I fix this?
Thank you.
Abel

SInce we had several improvements on the examples maybe it will a good idea to update the live examples on our gh-pages branch.
Any comments or concerns?

We need components for the MapFish Print module.

I'm trying to modify the summits.json file location changing the url on line 72 of the Map's controller (I'm using app.js, not app-all.js)... The web server doesn't change the summits.json location... Server response: "GET http://server.domain/data/summits.json 404 not found" and the reference file is "OpenLayers.js on line 748"...

I've tryed changing it using app-all.js too and modifying the line in this file but I've got the same response...

I have to move the file to the desired location if I want to run it... I can't configure it as needed...

TIA,
baux

According to the mailinglist discussion http://www.geoext.org/pipermail/dev/2012-July/001147.html I open up this issue, to extend the LegendImage having a new event triggering that the legend image is fully loaded.

I have in mind that the print components should be renamed, due to the fact that MapFish print-servlet (and GeoServer-print?) are supported.
Is this still needed? If yes some proposals for new names are welcome.

We have tests that fail in IE8 that pass in all other 5 browsers : IE9, FF, Chrome, Opera and Safari. They may be caused by Test.AnotherWay, so we'll look at that later.

GeoExt 1 includes functions for serializing forms into filters (GeoExt.form.toFilter), and for creating fields from attribute records (GeoExt.form.recordToField). We need the same features in GeoExt 2.

We have GeoExt.Popup in GeoExt 1.

Frank shared some code to address this on the mailing list:

http://www.geoext.org/pipermail/users/2013-February/003225.html

but it appears to reinvent the wheel, and I haven't figured out how to adapt it yet for my project. This is such a basic feature requirement that it ideally it would be supported out-of-the-box, so I thought I'd inquire.

While I'm making up my christmas list, let me also wish for some config options to tame some of the complexities involved:

allowDragOfParent: boolean // default false?

Useful for keeping the "base" layer group always below below an "overlay" group, for example.

allowDragOntoNewParent: boolean // default false?

This would prevent, for example, a "base" layer from being dragged into an "overlay" layer, messing up the default nesting.

onDragError: function()

A callback called when the user does a disallowed drag.

The a slider is in the map, it hidden by it. See the following example:

http://geoext.github.com/geoext2/examples/zoomslider/zoomslider.html