geode-sdk / bindings Goto Github PK

sometimes functions are inlined in a lot of places, or are merged with other functions, which makes hooking a problem, even though itd still be nice to give them an address instead of having to reimplement the whole thing.

this commit breaks something related to floats, which breaks the geode mod list layer

51249f5

dont check this variable or add a binding to it

yeah

Would probably have to be some custom parser since we need to keep comments and such

I have a repository where I keep some 2.2 reverse engineered snippets I did after I forked Wyliemaster's own repository (Until he finally makes a 2.2 repository of his own) so I could explore some major components that were missing and that I wanted to learn more about.

So, I was wondering if it would be a good Idea to try and merge any reverse engineered code I find once I've changed the class member names to reflect the names provided by broma files. I feel like modders should know what is going on under the hood which is why I am asking about this now rather than later...

I have an example for a function I wanted to add (If it hasn't been done already) however it should be noted that these are not inline functions.

bool GameManager::getGameVariable(char * key){
    return m_pGameVariableDict->valueForKey(key)->boolValue();
}

some methods arent marked virtual when they should, and some are even virtual when they arent