genius257 / au3unit Goto Github PK

example: au3pm uses folder junctions to reference itself, from within installed packages.
Whilst circular folder references are a bad idea generally, au3unit should try and be able to prevent this.
Current use of the function "_FileListToArrayRec" is the cause.
A custom implementation of the function is needed, to detect and deal with junctions, symlinks & hardlinks.

assertTrue(False)
assertTrue(Null)
assertTrue("WRONG")
;No errors

This is caused because a mix of:

some matches methods (like Au3UnitConstraintIsTrue_Matches) returning a boolean instead of an Au3UnitExpectationFailedException

And:

Suggested fix:

If (IsBool($matches) And $matches) Or (Not IsBool($matches)) And $comparisonFailure = Null Then $success = True

Example code:

#include ".\au3pm\au3unit\Unit\assert.au3"
$a = ObjCreate("Scripting.Dictionary")
$b = ObjCreate("Scripting.Dictionary")
assertEquals($a, $b)

Output:

no comparator found!
1_assertEquals function is missing

This is also a problem when using objects in arrays.

This is expected, as PHP does not have general Ptr as a varaible type.
Expected fix is to add IsPtr to the condition checks, but testing is needed, to verify this gives expected behavior.

assertSame and by extent IsIdentical does not compare correctly.
$exspected == $other compares values as string representations. Furthermore var type also need to be verified.

'123' should not pass when matched against 123

Dim $a = ["test"]
assertSame($a, $a)

output:

Failed asserting that Array is identical to Array.

Your project references a path that isn't in the scope of this project, suggesting that:

• AutoIt executable should be here: \au3pm\autoit\autoit3.exe
• StringRegExpSplit.au3 should be here: ..\au3pm\StringRegExpSplit.au3

Also, some documentation would be awesome, because I'd love to start using this but don't know where to begin. Alternately, I'd be happy to work on documentation if you'd put a few examples in so I know where to start :D

Configuration file support is needed. Something like the phpunit.xml XML configuration file.
This would make it easy to pre-configure path, test file match filter and such.

if AutoIt3.exe execution from the autoit dependency fails, each test is reported as an error, with no message

This makes the include path for package references less obtuse and will allow functionality like applying a global setup function.

assertCount

I'm assuming it will be Ubound($array, 1), with some extra parameter to change the default dimension to assert?